From: Piergiorgio Sartor <piergiorgio.sartor@nexgo.de>
To: NeilBrown <neilb@suse.de>
Cc: Piergiorgio Sartor <piergiorgio.sartor@nexgo.de>,
linux-raid@vger.kernel.org
Subject: [PATCH] RAID-6 check standalone suspend array
Date: Sun, 8 May 2011 20:54:08 +0200 [thread overview]
Message-ID: <20110508185408.GA25378@lazy.lzy> (raw)
In-Reply-To: <20110405091242.3427e0b1@notabene.brown>
Hi Neil,
please find below a small patch which should suspend the
array while reading the stripes in order to perform the
check of the RAID-6.
This should complete the "check" part of the SW.
Please let me know what else could be needed (docs,
test or else).
Please have a careful look at it, since I did not know
how to test it.
Thanks.
--- cut here ---
diff -uNr a/raid6check.c b/raid6check.c
--- a/raid6check.c 2011-05-07 20:35:18.693370007 +0200
+++ b/raid6check.c 2011-05-07 21:00:07.713865939 +0200
@@ -24,6 +24,7 @@
#include "mdadm.h"
#include <stdint.h>
+#include <signal.h>
int geo_map(int block, unsigned long long stripe, int raid_disks,
int level, int layout);
@@ -99,7 +100,7 @@
return curr_broken_disk;
}
-int check_stripes(int *source, unsigned long long *offsets,
+int check_stripes(struct mdinfo *info, int *source, unsigned long long *offsets,
int raid_disks, int chunk_size, int level, int layout,
unsigned long long start, unsigned long long length, char *name[])
{
@@ -139,10 +140,22 @@
printf("pos --> %llu\n", start);
+ signal(SIGTERM, SIG_IGN);
+ signal(SIGINT, SIG_IGN);
+ signal(SIGQUIT, SIG_IGN);
+ sysfs_set_num(info, NULL, "suspend_lo", start * data_disks);
+ sysfs_set_num(info, NULL, "suspend_hi", (start + chunk_size) * data_disks);
for (i = 0 ; i < raid_disks ; i++) {
lseek64(source[i], offsets[i] + start * chunk_size, 0);
read(source[i], stripes[i], chunk_size);
}
+ sysfs_set_num(info, NULL, "suspend_lo", 0x7FFFFFFFFFFFFFFFULL);
+ sysfs_set_num(info, NULL, "suspend_hi", 0);
+ sysfs_set_num(info, NULL, "suspend_lo", 0);
+ signal(SIGQUIT, SIG_DFL);
+ signal(SIGINT, SIG_DFL);
+ signal(SIGTERM, SIG_DFL);
+
for (i = 0 ; i < data_disks ; i++) {
int disk = geo_map(i, start, raid_disks, level, layout);
blocks[i] = stripes[disk];
@@ -343,7 +356,7 @@
comp = comp->next;
}
- int rv = check_stripes(fds, offsets,
+ int rv = check_stripes(info, fds, offsets,
raid_disks, chunk_size, level, layout,
start, length, disk_name);
if (rv != 0) {
--- cut here ---
bye,
--
piergiorgio
next prev parent reply other threads:[~2011-05-08 18:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 20:45 [PATCH] RAID-6 check standalone Piergiorgio Sartor
2011-03-07 19:33 ` Piergiorgio Sartor
2011-03-21 3:02 ` NeilBrown
2011-03-21 10:40 ` Piergiorgio Sartor
2011-03-21 11:04 ` NeilBrown
2011-03-21 11:54 ` Piergiorgio Sartor
2011-03-21 22:59 ` NeilBrown
2011-03-31 18:53 ` [PATCH] RAID-6 check standalone md device Piergiorgio Sartor
[not found] ` <4D96597C.1020103@tuxes.nl>
[not found] ` <20110402071310.GA2640@lazy.lzy>
2011-04-02 10:33 ` Bas van Schaik
2011-04-02 11:03 ` Piergiorgio Sartor
2011-04-04 23:01 ` NeilBrown
2011-04-05 19:56 ` Piergiorgio Sartor
2011-04-04 17:52 ` [PATCH] RAID-6 check standalone code cleanup Piergiorgio Sartor
2011-04-04 23:12 ` NeilBrown
2011-04-06 18:02 ` Piergiorgio Sartor
2011-04-13 20:48 ` [PATCH] RAID-6 check standalone fix component list parsing Piergiorgio Sartor
2011-04-14 7:29 ` NeilBrown
2011-04-14 7:32 ` [PATCH] RAID-6 check standalone code cleanup NeilBrown
2011-05-08 18:54 ` Piergiorgio Sartor [this message]
2011-05-09 1:45 ` [PATCH] RAID-6 check standalone suspend array NeilBrown
2011-05-09 18:43 ` [PATCH] RAID-6 check standalone suspend array V2.0 Piergiorgio Sartor
2011-05-15 21:15 ` Piergiorgio Sartor
2011-05-16 10:08 ` NeilBrown
2011-07-20 17:57 ` Piergiorgio Sartor
2011-07-22 6:41 ` Luca Berra
2011-07-25 18:53 ` Piergiorgio Sartor
2011-07-26 5:25 ` NeilBrown
2011-08-07 17:09 ` [PATCH] RAID-6 check standalone man page Piergiorgio Sartor
2011-08-09 0:43 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110508185408.GA25378@lazy.lzy \
--to=piergiorgio.sartor@nexgo.de \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).