From: Jonathan Brassow <jbrassow@f14.redhat.com>
To: linux-raid@vger.kernel.org
Subject: [PATCH 2 of 9] MD: should_read_superblock
Date: Mon, 23 May 2011 22:06:09 -0500 [thread overview]
Message-ID: <201105240306.p4O369g2029293@f14.redhat.com> (raw)
Patch name: md-should_read_superblock.patch
Add new function to determine whether MD superblocks should be read.
It used to be sufficient to check if mddev->raid_disks was set to determine
whether to read the superblock or not. However, device-mapper (dm-raid.c)
sets this value before calling md_run(). Thus, we need additional mechanisms
for determining whether to read the superblock. This patch adds the condition
that if rdev->meta_bdev is set, the superblock should be read - something that
only device-mapper does (and only when there are superblocks to be read/used).
Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Index: linux-2.6/drivers/md/md.c
===================================================================
--- linux-2.6.orig/drivers/md/md.c
+++ linux-2.6/drivers/md/md.c
@@ -4421,6 +4421,20 @@ static void md_safemode_timeout(unsigned
md_wakeup_thread(mddev->thread);
}
+static int should_read_super(mddev_t *mddev)
+{
+ mdk_rdev_t *rdev, *tmp;
+
+ if (!mddev->raid_disks)
+ return 1;
+
+ rdev_for_each(rdev, tmp, mddev)
+ if (rdev->meta_bdev)
+ return 1;
+
+ return 0;
+}
+
static int start_dirty_degraded;
int md_run(mddev_t *mddev)
@@ -4442,7 +4456,7 @@ int md_run(mddev_t *mddev)
/*
* Analyze all RAID superblock(s)
*/
- if (!mddev->raid_disks) {
+ if (should_read_super(mddev)) {
if (!mddev->persistent)
return -EINVAL;
analyze_sbs(mddev);
next reply other threads:[~2011-05-24 3:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 3:06 Jonathan Brassow [this message]
2011-05-25 4:01 ` [PATCH 2 of 9] MD: should_read_superblock NeilBrown
2011-05-25 14:00 ` Jonathan Brassow
2011-05-26 0:32 ` NeilBrown
2011-05-26 14:50 ` Jonathan Brassow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105240306.p4O369g2029293@f14.redhat.com \
--to=jbrassow@f14.redhat.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).