From: NeilBrown <neilb@suse.de>
To: Jonathan Brassow <jbrassow@f14.redhat.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 1 of 9] MD: possible typo
Date: Wed, 25 May 2011 08:18:08 +1000 [thread overview]
Message-ID: <20110525081808.32264b34@notabene.brown> (raw)
In-Reply-To: <201105240305.p4O35wmb029220@f14.redhat.com>
On Mon, 23 May 2011 22:05:58 -0500 Jonathan Brassow <jbrassow@f14.redhat.com>
wrote:
> Patch name: md-possible-typo.patch
>
> Fix a value printed in kiB but labeled as 'blocks'.
>
> Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
>
> Index: linux-2.6/drivers/md/md.c
> ===================================================================
> --- linux-2.6.orig/drivers/md/md.c
> +++ linux-2.6/drivers/md/md.c
> @@ -6867,7 +6867,7 @@ void md_do_sync(mddev_t *mddev)
> */
> window = 32*(PAGE_SIZE/512);
> printk(KERN_INFO "md: using %dk window, over a total of %llu blocks.\n",
> - window/2,(unsigned long long) max_sectors/2);
> + window/2, (unsigned long long) max_sectors);
>
> atomic_set(&mddev->recovery_active, 0);
> last_check = 0;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
"blocks" has traditionally meant "kibibytes" in md nomenclature, so this was
"correct".
I'd be quite happy to change the word "blocks" to "KB" (or even "KiB") though.
NeilBrown
prev parent reply other threads:[~2011-05-24 22:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 3:05 [PATCH 1 of 9] MD: possible typo Jonathan Brassow
2011-05-24 22:18 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110525081808.32264b34@notabene.brown \
--to=neilb@suse.de \
--cc=jbrassow@f14.redhat.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).