From: NeilBrown <neilb@suse.de>
To: Jonathan Brassow <jbrassow@redhat.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 6 of 9] MD: no sync IO while suspended
Date: Wed, 25 May 2011 14:10:23 +1000 [thread overview]
Message-ID: <20110525141023.3b3c91bf@notabene.brown> (raw)
In-Reply-To: <201105240306.p4O36rFK029586@f14.redhat.com>
On Mon, 23 May 2011 22:06:53 -0500 Jonathan Brassow <jbrassow@f14.redhat.com>
wrote:
> Patch name: md-no-sync-IO-while-suspended.patch
>
> Disallow resync I/O while the RAID array is suspended.
>
> Recovery, resync, and metadata I/O should not be allowed while a device is
> suspended.
>
> Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
>
> Index: linux-2.6/drivers/md/md.c
> ===================================================================
> --- linux-2.6.orig/drivers/md/md.c
> +++ linux-2.6/drivers/md/md.c
> @@ -7064,7 +7064,6 @@ void md_do_sync(mddev_t *mddev)
> }
> EXPORT_SYMBOL_GPL(md_do_sync);
>
> -
> static int remove_and_add_spares(mddev_t *mddev)
> {
> mdk_rdev_t *rdev;
> @@ -7176,6 +7175,9 @@ static void reap_sync_thread(mddev_t *md
> */
> void md_check_recovery(mddev_t *mddev)
> {
> + if (mddev->suspended)
> + return;
> +
> if (mddev->bitmap)
> bitmap_daemon_work(mddev);
>
Yep, applied.
Thanks,
NeilBrown
prev parent reply other threads:[~2011-05-25 4:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 3:06 [PATCH 6 of 9] MD: no sync IO while suspended Jonathan Brassow
2011-05-25 4:10 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110525141023.3b3c91bf@notabene.brown \
--to=neilb@suse.de \
--cc=jbrassow@redhat.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).