From: NeilBrown <neilb@suse.de>
To: Jonathan Brassow <jbrassow@redhat.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] MD: use is_power_of_2 macro
Date: Thu, 9 Jun 2011 11:44:27 +1000 [thread overview]
Message-ID: <20110609114427.625f0c1e@notabene.brown> (raw)
In-Reply-To: <1307556070.9555.11.camel@f14.redhat.com>
On Wed, 08 Jun 2011 13:01:10 -0500 Jonathan Brassow <jbrassow@redhat.com>
wrote:
> Make use of is_power_of_2 macro.
>
> Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
>
> Index: linux-2.6/drivers/md/bitmap.c
> ===================================================================
> --- linux-2.6.orig/drivers/md/bitmap.c
> +++ linux-2.6/drivers/md/bitmap.c
> @@ -651,7 +651,7 @@ static int bitmap_read_sb(struct bitmap
> reason = "unrecognized superblock version";
> else if (chunksize < 512)
> reason = "bitmap chunksize too small";
> - else if ((1 << ffz(~chunksize)) != chunksize)
> + else if (!is_power_of_2(chunksize))
> reason = "bitmap chunksize not a power of 2";
> else if (daemon_sleep < 1 || daemon_sleep > MAX_SCHEDULE_TIMEOUT)
> reason = "daemon sleep period out of range";
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jon,
thanks for this and the others.
I'll push them into my 'for-next' branch today so they should appear in -next
soon. I expect to send a pull request to Linus on Tuesday - after the long
weekend.
Thanks,
NeilBrown
prev parent reply other threads:[~2011-06-09 1:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 18:01 [PATCH] MD: use is_power_of_2 macro Jonathan Brassow
2011-06-09 1:44 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609114427.625f0c1e@notabene.brown \
--to=neilb@suse.de \
--cc=jbrassow@redhat.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).