* [PATCH] imsm: FIX: Sometimes reshape cannot be finished
@ 2011-06-14 12:56 Adam Kwolek
2011-06-14 23:15 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: Adam Kwolek @ 2011-06-14 12:56 UTC (permalink / raw)
To: neilb; +Cc: linux-raid, dan.j.williams, ed.ciechanowski, wojciech.neubauer
When array size is not aligned to copy area, number of migration unit
is increased in init_migr_record_imsm():7665 to reshape whole array.
During calculation of last migration unit, this should be in mind also,
otherwise checkpoint (max-1) is always written and reshape
is never finished in mdadm.
Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
---
super-intel.c | 18 ++++++++++++++----
1 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/super-intel.c b/super-intel.c
index 5dc8ca8..d525295 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -7788,20 +7788,30 @@ abort:
int save_checkpoint_imsm(struct supertype *st, struct mdinfo *info, int state)
{
struct intel_super *super = st->sb;
+ unsigned long long blocks_per_unit;
+
if (load_imsm_migr_rec(super, info) != 0) {
dprintf("imsm: ERROR: Cannot read migration record "
"for checkpoint save.\n");
return 1;
}
- if (__le32_to_cpu(super->migr_rec->blocks_per_unit) == 0) {
+ blocks_per_unit = __le32_to_cpu(super->migr_rec->blocks_per_unit);
+ if (blocks_per_unit == 0) {
dprintf("imsm: no migration in progress.\n");
return 2;
}
-
super->migr_rec->curr_migr_unit =
- __cpu_to_le32(info->reshape_progress /
- __le32_to_cpu(super->migr_rec->blocks_per_unit));
+ info->reshape_progress / blocks_per_unit;
+ /* check if array is alligned to copy area
+ * if it is not alligned, add one to current migration unit value
+ * this can happend on array reshape finish only
+ */
+ if (info->reshape_progress % blocks_per_unit)
+ super->migr_rec->curr_migr_unit++;
+ super->migr_rec->curr_migr_unit =
+ __cpu_to_le32(super->migr_rec->curr_migr_unit);
+
super->migr_rec->rec_status = __cpu_to_le32(state);
super->migr_rec->dest_1st_member_lba =
__cpu_to_le32((__le32_to_cpu(super->migr_rec->curr_migr_unit))
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] imsm: FIX: Sometimes reshape cannot be finished
2011-06-14 12:56 [PATCH] imsm: FIX: Sometimes reshape cannot be finished Adam Kwolek
@ 2011-06-14 23:15 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2011-06-14 23:15 UTC (permalink / raw)
To: Adam Kwolek
Cc: linux-raid, dan.j.williams, ed.ciechanowski, wojciech.neubauer
On Tue, 14 Jun 2011 14:56:22 +0200 Adam Kwolek <adam.kwolek@intel.com> wrote:
> When array size is not aligned to copy area, number of migration unit
> is increased in init_migr_record_imsm():7665 to reshape whole array.
> During calculation of last migration unit, this should be in mind also,
> otherwise checkpoint (max-1) is always written and reshape
> is never finished in mdadm.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
>
> super-intel.c | 18 ++++++++++++++----
> 1 files changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index 5dc8ca8..d525295 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -7788,20 +7788,30 @@ abort:
> int save_checkpoint_imsm(struct supertype *st, struct mdinfo *info, int state)
> {
> struct intel_super *super = st->sb;
> + unsigned long long blocks_per_unit;
> +
> if (load_imsm_migr_rec(super, info) != 0) {
> dprintf("imsm: ERROR: Cannot read migration record "
> "for checkpoint save.\n");
> return 1;
> }
>
> - if (__le32_to_cpu(super->migr_rec->blocks_per_unit) == 0) {
> + blocks_per_unit = __le32_to_cpu(super->migr_rec->blocks_per_unit);
> + if (blocks_per_unit == 0) {
> dprintf("imsm: no migration in progress.\n");
> return 2;
> }
> -
> super->migr_rec->curr_migr_unit =
> - __cpu_to_le32(info->reshape_progress /
> - __le32_to_cpu(super->migr_rec->blocks_per_unit));
> + info->reshape_progress / blocks_per_unit;
> + /* check if array is alligned to copy area
> + * if it is not alligned, add one to current migration unit value
> + * this can happend on array reshape finish only
> + */
> + if (info->reshape_progress % blocks_per_unit)
> + super->migr_rec->curr_migr_unit++;
> + super->migr_rec->curr_migr_unit =
> + __cpu_to_le32(super->migr_rec->curr_migr_unit);
> +
> super->migr_rec->rec_status = __cpu_to_le32(state);
> super->migr_rec->dest_1st_member_lba =
> __cpu_to_le32((__le32_to_cpu(super->migr_rec->curr_migr_unit))
I think it is a bit untidy storing a value in cpu-order in super->migr_rec
and then changing it to little-endian later. It feels error prone.
So I have changed it to use a local variable for the cpu-order version as
below.
Thanks,
NeilBrown
commit f8b72ef517ea305f714230b0503f94ae5f1b8fa4
Author: Adam Kwolek <adam.kwolek@intel.com>
Date: Wed Jun 15 09:13:49 2011 +1000
imsm: FIX: Sometimes reshape cannot be finished
When array size is not aligned to copy area, number of migration unit
is increased in init_migr_record_imsm():7665 to reshape whole array.
During calculation of last migration unit, this should be in mind also,
otherwise checkpoint (max-1) is always written and reshape
is never finished in mdadm.
Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
diff --git a/super-intel.c b/super-intel.c
index 5dc8ca8..bb76f74 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -7788,24 +7788,34 @@ abort:
int save_checkpoint_imsm(struct supertype *st, struct mdinfo *info, int state)
{
struct intel_super *super = st->sb;
+ unsigned long long blocks_per_unit;
+ unsigned long long curr_migr_unit;
+
if (load_imsm_migr_rec(super, info) != 0) {
dprintf("imsm: ERROR: Cannot read migration record "
"for checkpoint save.\n");
return 1;
}
- if (__le32_to_cpu(super->migr_rec->blocks_per_unit) == 0) {
+ blocks_per_unit = __le32_to_cpu(super->migr_rec->blocks_per_unit);
+ if (blocks_per_unit == 0) {
dprintf("imsm: no migration in progress.\n");
return 2;
}
+ curr_migr_unit = info->reshape_progress / blocks_per_unit;
+ /* check if array is alligned to copy area
+ * if it is not alligned, add one to current migration unit value
+ * this can happend on array reshape finish only
+ */
+ if (info->reshape_progress % blocks_per_unit)
+ curr_migr_unit++;
super->migr_rec->curr_migr_unit =
- __cpu_to_le32(info->reshape_progress /
- __le32_to_cpu(super->migr_rec->blocks_per_unit));
+ __cpu_to_le32(curr_migr_unit);
super->migr_rec->rec_status = __cpu_to_le32(state);
super->migr_rec->dest_1st_member_lba =
- __cpu_to_le32((__le32_to_cpu(super->migr_rec->curr_migr_unit))
- * __le32_to_cpu(super->migr_rec->dest_depth_per_unit));
+ __cpu_to_le32(curr_migr_unit *
+ __le32_to_cpu(super->migr_rec->dest_depth_per_unit));
if (write_imsm_migr_rec(st) < 0) {
dprintf("imsm: Cannot write migration record "
"outside backup area\n");
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-14 23:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-14 12:56 [PATCH] imsm: FIX: Sometimes reshape cannot be finished Adam Kwolek
2011-06-14 23:15 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).