linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Namhyung Kim <namhyung@gmail.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] md: remove ro check in md_check_recovery()
Date: Thu, 14 Jul 2011 13:54:38 +1000	[thread overview]
Message-ID: <20110714135438.24e26684@notabene.brown> (raw)
In-Reply-To: <1309984866-2228-1-git-send-email-namhyung@gmail.com>

On Thu,  7 Jul 2011 05:41:06 +0900 Namhyung Kim <namhyung@gmail.com> wrote:

> Commit c89a8eee6154 ("Allow faulty devices to be removed from a
> readonly array.") added some work on ro array in the function,
> but it couldn't be done since we didn't allow the ro array to be
> handled from the beginning. Fix it.
> 
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> ---
>  drivers/md/md.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 53e8d75314c3..a4022e679b63 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -7179,9 +7179,6 @@ void md_check_recovery(mddev_t *mddev)
>  	if (mddev->bitmap)
>  		bitmap_daemon_work(mddev);
>  
> -	if (mddev->ro)
> -		return;
> -
>  	if (signal_pending(current)) {
>  		if (mddev->pers->sync_request && !mddev->external) {
>  			printk(KERN_INFO "md: %s in immediate safe mode\n",


Applied, thanks.

NeilBrown

      reply	other threads:[~2011-07-14  3:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-06 20:41 [PATCH] md: remove ro check in md_check_recovery() Namhyung Kim
2011-07-14  3:54 ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110714135438.24e26684@notabene.brown \
    --to=neilb@suse.de \
    --cc=linux-raid@vger.kernel.org \
    --cc=namhyung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).