* [PATCH] md: remove ro check in md_check_recovery()
@ 2011-07-06 20:41 Namhyung Kim
2011-07-14 3:54 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: Namhyung Kim @ 2011-07-06 20:41 UTC (permalink / raw)
To: Neil Brown; +Cc: linux-raid
Commit c89a8eee6154 ("Allow faulty devices to be removed from a
readonly array.") added some work on ro array in the function,
but it couldn't be done since we didn't allow the ro array to be
handled from the beginning. Fix it.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
drivers/md/md.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 53e8d75314c3..a4022e679b63 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -7179,9 +7179,6 @@ void md_check_recovery(mddev_t *mddev)
if (mddev->bitmap)
bitmap_daemon_work(mddev);
- if (mddev->ro)
- return;
-
if (signal_pending(current)) {
if (mddev->pers->sync_request && !mddev->external) {
printk(KERN_INFO "md: %s in immediate safe mode\n",
--
1.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] md: remove ro check in md_check_recovery()
2011-07-06 20:41 [PATCH] md: remove ro check in md_check_recovery() Namhyung Kim
@ 2011-07-14 3:54 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2011-07-14 3:54 UTC (permalink / raw)
To: Namhyung Kim; +Cc: linux-raid
On Thu, 7 Jul 2011 05:41:06 +0900 Namhyung Kim <namhyung@gmail.com> wrote:
> Commit c89a8eee6154 ("Allow faulty devices to be removed from a
> readonly array.") added some work on ro array in the function,
> but it couldn't be done since we didn't allow the ro array to be
> handled from the beginning. Fix it.
>
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> ---
> drivers/md/md.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 53e8d75314c3..a4022e679b63 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -7179,9 +7179,6 @@ void md_check_recovery(mddev_t *mddev)
> if (mddev->bitmap)
> bitmap_daemon_work(mddev);
>
> - if (mddev->ro)
> - return;
> -
> if (signal_pending(current)) {
> if (mddev->pers->sync_request && !mddev->external) {
> printk(KERN_INFO "md: %s in immediate safe mode\n",
Applied, thanks.
NeilBrown
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-14 3:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-06 20:41 [PATCH] md: remove ro check in md_check_recovery() Namhyung Kim
2011-07-14 3:54 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).