From: NeilBrown <neilb@suse.de>
To: Randy Dunlap <rdunlap@xenotime.net>,
Jonathan Brassow <jbrassow@redhat.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-raid@vger.kernel.org, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
dm-devel@redhat.com
Subject: Re: linux-next: Tree for July 21 (drivers/md/dm-raid)
Date: Fri, 22 Jul 2011 08:10:40 +1000 [thread overview]
Message-ID: <20110722081040.48abfff1@notabene.brown> (raw)
In-Reply-To: <20110721145648.2477f8bb.rdunlap@xenotime.net>
On Thu, 21 Jul 2011 14:56:48 -0700 Randy Dunlap <rdunlap@xenotime.net> wrote:
> On Thu, 21 Jul 2011 16:55:42 +1000 Stephen Rothwell wrote:
>
> > Hi all,
>
> When CONFIG_DM_RAID=m and CONFIG_MD_RAID1 is not enabled:
>
> ERROR: "md_raid1_congested" [drivers/md/dm-raid.ko] undefined!
>
> due to:
>
> if (rs->raid_type->level == 1)
> return md_raid1_congested(&rs->md, bits);
>
> Should that just be surrounded with this?
>
> #if defined(CONFIG_MD_RAID1) || defined(CONFIG_MD_RAID1_MODULE)
> ...
> #endif
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
I suspect the right thing to do is add
select MD_RAID1
to the
config DM_RAID
stanza. What do you think Jon?
NeilBrown
next prev parent reply other threads:[~2011-07-21 22:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110721165542.7748c88a1d1e0b228c7fe3fa@canb.auug.org.au>
2011-07-21 21:56 ` linux-next: Tree for July 21 (drivers/md/dm-raid) Randy Dunlap
2011-07-21 22:10 ` NeilBrown [this message]
2011-07-22 1:14 ` [dm-devel] " Alasdair G Kergon
2011-07-21 23:10 ` [PATCH -next] dm: fix dm-flakey printk warning Randy Dunlap
2011-07-22 16:25 ` [dm-devel] " Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110722081040.48abfff1@notabene.brown \
--to=neilb@suse.de \
--cc=dm-devel@redhat.com \
--cc=jbrassow@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).