linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Michal Soltys <soltys@ziu.info>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 0/2] udev rules behaviour
Date: Wed, 7 Sep 2011 14:00:02 +1000	[thread overview]
Message-ID: <20110907140002.0792061c@notabene.brown> (raw)
In-Reply-To: <1315140164-6991-1-git-send-email-soltys@ziu.info>

On Sun,  4 Sep 2011 14:42:42 +0200 Michal Soltys <soltys@ziu.info> wrote:

> Current udev rules installed cause autoassembly of everything that is possible
> during coldplug - due to mdadm -I calls for each matching device.
> 
> This causes two immediate problems:
> 
> - mdadm.conf kind-of rendered pointless, as the assembly of any array will be
>   attempted either way
> 
> - 65-md-inc*.rules (e.g. present in dracut and different distributions)
>   offering more fine grained controls (e.g. incremental assembly limited to
>   certain uuids) are also shadowed by mdadm's default rules
> 
> If this is not expected behaviour, following patch removes -I calls.
> Second patch adds ddf (and any future) containers to -If calls.
> 
> 
> Alternatively, we could detect presence of 65-md-inc* and mdadm.conf and
> attempt assemlby only if none of those are present ? Not perfect, but
> a bit more flexible.
> 

hi Michal,
 thanks for raising this.

I find it unfortunate that someone would ship an md-specific rules file
without even discussing it with me or on this list.  That can easily lead to
inconsistent or suboptimal behaviour.

It isn't entirely true that calling "mdadm -I" on all devices makes
mdadm.conf pointless.
If you put "auto -all" in mdadm.conf it will disable all auto-assembly and
will only assemble arrays that are explicitly listed in mdadm.conf.

So I'm not really sure what that problem is here.

Can you give me an example of a situation that cannot be handled with the
mdadm udev rules as they are?

I like your "shorten remove rules" patch and will apply that.

Thanks,
NeilBrown



  parent reply	other threads:[~2011-09-07  4:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-04 12:42 [PATCH 0/2] udev rules behaviour Michal Soltys
2011-09-04 12:42 ` [PATCH 1/2] udev rules: don't incrementally autoassemble everything Michal Soltys
2011-09-04 12:42 ` [PATCH 2/2] shorten remove rules Michal Soltys
2011-09-06 21:39 ` v2 - keep incremental, check types Michal Soltys
2011-09-06 21:39   ` [PATCH] udev rules: add ddf, shorten checks, use $tempnode Michal Soltys
2011-09-07  4:00 ` NeilBrown [this message]
2011-09-08  7:25 ` v2 once more, for current head Michal Soltys
2011-09-08  7:25   ` [PATCH] udev rules: use $tempnode, check for supported types, comments Michal Soltys
2011-09-19  3:12     ` NeilBrown
2011-09-19  7:23       ` Michal Soltys

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110907140002.0792061c@notabene.brown \
    --to=neilb@suse.de \
    --cc=linux-raid@vger.kernel.org \
    --cc=soltys@ziu.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).