* [PATCH] fix: segfault when killing subarray of non-existent container
@ 2011-08-01 15:33 Czarnowska, Anna
2011-08-05 21:44 ` Dan Williams
0 siblings, 1 reply; 3+ messages in thread
From: Czarnowska, Anna @ 2011-08-01 15:33 UTC (permalink / raw)
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org, Williams, Dan J, Ciechanowski, Ed,
Hawrylewicz Czarnowski, Przemyslaw, Grabowski, Grzegorz
From 9c3c974e1e047caf3434f98e183e58ed3b222396 Mon Sep 17 00:00:00 2001
From: Anna Czarnowska <anna.czarnowska@intel.com>
Date: Mon, 1 Aug 2011 17:23:33 +0200
Subject: [PATCH] fix: segfault when killing subarray of non-existent container
Negative value must be returned to indicate error in open_subarray
Signed-off-by: Anna Czarnowska <anna.czarnowska@intel.com>
---
util.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/util.c b/util.c
index 55d171a..2dec9d5 100644
--- a/util.c
+++ b/util.c
@@ -1369,7 +1369,7 @@ int open_subarray(char *dev, char *subarray, struct supertype *st, int quiet)
if (!quiet)
fprintf(stderr, Name ": Couldn't open %s, aborting\n",
dev);
- return 2;
+ return -1;
}
st->devnum = fd2devnum(fd);
--
1.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fix: segfault when killing subarray of non-existent container
2011-08-01 15:33 [PATCH] fix: segfault when killing subarray of non-existent container Czarnowska, Anna
@ 2011-08-05 21:44 ` Dan Williams
2011-09-07 4:10 ` NeilBrown
0 siblings, 1 reply; 3+ messages in thread
From: Dan Williams @ 2011-08-05 21:44 UTC (permalink / raw)
To: Czarnowska, Anna
Cc: neilb@suse.de, linux-raid@vger.kernel.org, Ciechanowski, Ed,
Hawrylewicz Czarnowski, Przemyslaw, Grabowski, Grzegorz
On Mon, Aug 1, 2011 at 8:33 AM, Czarnowska, Anna
<anna.czarnowska@intel.com> wrote:
> From 9c3c974e1e047caf3434f98e183e58ed3b222396 Mon Sep 17 00:00:00 2001
> From: Anna Czarnowska <anna.czarnowska@intel.com>
> Date: Mon, 1 Aug 2011 17:23:33 +0200
> Subject: [PATCH] fix: segfault when killing subarray of non-existent container
>
> Negative value must be returned to indicate error in open_subarray
>
> Signed-off-by: Anna Czarnowska <anna.czarnowska@intel.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix: segfault when killing subarray of non-existent container
2011-08-05 21:44 ` Dan Williams
@ 2011-09-07 4:10 ` NeilBrown
0 siblings, 0 replies; 3+ messages in thread
From: NeilBrown @ 2011-09-07 4:10 UTC (permalink / raw)
To: Dan Williams
Cc: Czarnowska, Anna, linux-raid@vger.kernel.org, Ciechanowski, Ed,
Hawrylewicz Czarnowski, Przemyslaw, Grabowski, Grzegorz
On Fri, 5 Aug 2011 14:44:45 -0700 Dan Williams <dan.j.williams@intel.com>
wrote:
> On Mon, Aug 1, 2011 at 8:33 AM, Czarnowska, Anna
> <anna.czarnowska@intel.com> wrote:
> > From 9c3c974e1e047caf3434f98e183e58ed3b222396 Mon Sep 17 00:00:00 2001
> > From: Anna Czarnowska <anna.czarnowska@intel.com>
> > Date: Mon, 1 Aug 2011 17:23:33 +0200
> > Subject: [PATCH] fix: segfault when killing subarray of non-existent container
> >
> > Negative value must be returned to indicate error in open_subarray
> >
> > Signed-off-by: Anna Czarnowska <anna.czarnowska@intel.com>
>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Thanks,
I have - somewhat belatedly - applied this now.
Thanks,
NeilBrown
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-07 4:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-01 15:33 [PATCH] fix: segfault when killing subarray of non-existent container Czarnowska, Anna
2011-08-05 21:44 ` Dan Williams
2011-09-07 4:10 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).