From: NeilBrown <neilb@suse.de>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: linux-raid@vger.kernel.org, Anna Czarnowska <anna.czarnowska@intel.com>
Subject: Re: [PATCH] GCC compile fix: remove calculation of unused variable 'reservation'
Date: Thu, 27 Oct 2011 15:33:08 +1100 [thread overview]
Message-ID: <20111027153308.7e6cbe48@notabene.brown> (raw)
In-Reply-To: <4EA80258.70302@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
On Wed, 26 Oct 2011 14:51:36 +0200 Jes Sorensen <Jes.Sorensen@redhat.com>
wrote:
> On 10/06/11 16:43, Jes.Sorensen@redhat.com wrote:
> > From: Jes Sorensen <Jes.Sorensen@redhat.com>
> >
> > gcc 4.6.1 doesn't like calculating a variable that then isn't
> > used. Remove it.
> >
> > Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
> > ---
> > super-intel.c | 2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
>
> Neil,
>
> Any chance you could reply this one? It still seems to be an issue with
> the latest git tree.
>
> Thanks,
> Jes
Yeah - sorry. I wanted to check that it really should be removed and there
wasn't some other bug hiding - but I looks like it is simply unnecessary.
Hopefully Anna will correct me if I'm wrong...
I''ve applied your patch.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2011-10-27 4:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 14:43 [PATCH] GCC compile fix: remove calculation of unused variable 'reservation' Jes.Sorensen
2011-10-26 12:51 ` Jes Sorensen
2011-10-27 4:33 ` NeilBrown [this message]
2011-10-27 7:46 ` Czarnowska, Anna
2011-10-27 8:01 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111027153308.7e6cbe48@notabene.brown \
--to=neilb@suse.de \
--cc=Jes.Sorensen@redhat.com \
--cc=anna.czarnowska@intel.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).