From: NeilBrown <neilb@suse.de>
To: "Labun, Marcin" <Marcin.Labun@intel.com>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"Kwolek, Adam" <adam.kwolek@intel.com>
Subject: Re: [PATCH] kill-subarray: fix, IMSM cannot kill-subarray with unsupported metadata
Date: Mon, 7 Nov 2011 12:34:11 +1100 [thread overview]
Message-ID: <20111107123411.3751cd50@notabene.brown> (raw)
In-Reply-To: <F9123E44003394499FDD2B17C60621D4044D82@IRSMSX101.ger.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
On Thu, 3 Nov 2011 15:23:03 +0000 "Labun, Marcin" <Marcin.Labun@intel.com>
wrote:
> Hi Neil,
> This is OK.
> However, reshape_container (called from Grow_continue_command) ignores info that is chosen by subarray string given by user.
> Therefore, all container's arrays are possibly grown (including those we want to block)
> So we need to patch Grow_continue, so it performs grow on the array that user requested, not all arrays that are in the reshape process.
> Thanks,
> Marcin
>
I don't think I understand...
When continuing a grow the user shouldn't need to specify which subarray
needs to be continued. That information is in the metadata.
So use just says "--grow --continue" and mdadm looks at the container to see
which arrays are in the middle of a reshape and continues those.
If one of them is such that the next array must be reshaped when this one
completes, that should just happen automatically too.
??
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2011-11-07 1:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 14:46 [PATCH] kill-subarray: fix, IMSM cannot kill-subarray with unsupported metadata Labun, Marcin
2011-10-31 0:31 ` NeilBrown
2011-10-31 16:52 ` Labun, Marcin
2011-11-01 4:48 ` NeilBrown
2011-11-03 15:23 ` Labun, Marcin
2011-11-07 1:34 ` NeilBrown [this message]
2011-11-10 10:00 ` Labun, Marcin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111107123411.3751cd50@notabene.brown \
--to=neilb@suse.de \
--cc=Marcin.Labun@intel.com \
--cc=adam.kwolek@intel.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).