* Error when compiling drivers/md/dm-bufio.c @ 2011-11-07 8:22 Witold Baryluk 2011-11-07 13:46 ` [dm-devel] " Alasdair G Kergon 0 siblings, 1 reply; 10+ messages in thread From: Witold Baryluk @ 2011-11-07 8:22 UTC (permalink / raw) To: Neil Brown; +Cc: dm-devel, linux-raid, Mikulas Patocka, Alasdair G Kergon I just got error on todays Linus' tree CC [M] drivers/md/dm-bufio.o drivers/md/dm-bufio.c:988:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:988:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:988:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:997:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:997:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:997:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1006:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1006:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:1006:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1036:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1036:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:1036:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1049:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1049:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:1049:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1059:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1059:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:1059:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1135:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1135:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:1135:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1158:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1158:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:1158:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1232:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1232:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:1232:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1238:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1238:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:1238:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1245:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1245:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:1245:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1251:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1251:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:1251:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1257:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1257:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:1257:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1263:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1263:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:1263:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1269:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1269:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:1269:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1489:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1489:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:1489:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1534:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1534:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/dm-bufio.c:1534:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1676:63: error: expected ‘)’ before ‘ulong’ drivers/md/dm-bufio.c:1677:40: error: expected ‘)’ before string constant drivers/md/dm-bufio.c:1679:55: error: expected ‘)’ before ‘uint’ drivers/md/dm-bufio.c:1680:35: error: expected ‘)’ before string constant drivers/md/dm-bufio.c:1682:67: error: expected ‘)’ before ‘ulong’ drivers/md/dm-bufio.c:1683:40: error: expected ‘)’ before string constant drivers/md/dm-bufio.c:1685:79: error: expected ‘)’ before ‘ulong’ drivers/md/dm-bufio.c:1686:46: error: expected ‘)’ before string constant drivers/md/dm-bufio.c:1688:87: error: expected ‘)’ before ‘ulong’ drivers/md/dm-bufio.c:1689:50: error: expected ‘)’ before string constant drivers/md/dm-bufio.c:1691:73: error: expected ‘)’ before ‘ulong’ drivers/md/dm-bufio.c:1692:43: error: expected ‘)’ before string constant drivers/md/dm-bufio.c:1694:73: error: expected ‘)’ before ‘ulong’ drivers/md/dm-bufio.c:1695:43: error: expected ‘)’ before string constant drivers/md/dm-bufio.c:1697:15: error: expected declaration specifiers or ‘...’ before string constant drivers/md/dm-bufio.c:1698:20: error: expected declaration specifiers or ‘...’ before string constant drivers/md/dm-bufio.c:1699:16: error: expected declaration specifiers or ‘...’ before string constant make[2]: *** [drivers/md/dm-bufio.o] Błąd 1 make[1]: *** [drivers/md] Błąd 2 make: *** [drivers] Błąd 2 COde is new, so it probably new bug not regression. Regards, Witek -- Witold Baryluk -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dm-devel] Error when compiling drivers/md/dm-bufio.c 2011-11-07 8:22 Error when compiling drivers/md/dm-bufio.c Witold Baryluk @ 2011-11-07 13:46 ` Alasdair G Kergon 2011-11-07 15:36 ` Mikulas Patocka 0 siblings, 1 reply; 10+ messages in thread From: Alasdair G Kergon @ 2011-11-07 13:46 UTC (permalink / raw) To: Witold Baryluk Cc: Neil Brown, linux-raid, dm-devel, Mikulas Patocka, Linus Torvalds On Mon, Nov 07, 2011 at 09:22:31AM +0100, Witold Baryluk wrote: > I just got error on todays Linus' tree > CC [M] drivers/md/dm-bufio.o > drivers/md/dm-bufio.c:988:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] Probably related to this merge: commit 32aaeffbd4a7457bf2f7448b33b5946ff2a960eb Merge branch 'modsplit-Oct31_2011' of git://git.kernel.org/pub/scm/linux/ker Previously module.h was included via another header file. Now, bufio.c needs an explicit #include <linux/module.h> Alasdair -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dm-devel] Error when compiling drivers/md/dm-bufio.c 2011-11-07 13:46 ` [dm-devel] " Alasdair G Kergon @ 2011-11-07 15:36 ` Mikulas Patocka 2011-11-07 16:15 ` Witold Baryluk 2011-11-07 16:18 ` Linus Torvalds 0 siblings, 2 replies; 10+ messages in thread From: Mikulas Patocka @ 2011-11-07 15:36 UTC (permalink / raw) To: Witold Baryluk, Linus Torvalds Cc: Alasdair G Kergon, Neil Brown, linux-raid, dm-devel [-- Attachment #1: Type: TEXT/PLAIN, Size: 1306 bytes --] On Mon, 7 Nov 2011, Alasdair G Kergon wrote: > On Mon, Nov 07, 2011 at 09:22:31AM +0100, Witold Baryluk wrote: > > I just got error on todays Linus' tree > > CC [M] drivers/md/dm-bufio.o > > drivers/md/dm-bufio.c:988:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] > > Probably related to this merge: > commit 32aaeffbd4a7457bf2f7448b33b5946ff2a960eb > Merge branch 'modsplit-Oct31_2011' of git://git.kernel.org/pub/scm/linux/ker > > Previously module.h was included via another header file. > Now, bufio.c needs an explicit > > #include <linux/module.h> > > Alasdair > Yes, apply this patch: dm-bufio: Include <linux/module.h> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> --- drivers/md/dm-bufio.c | 1 + 1 file changed, 1 insertion(+) Index: linux-2.6-compile/drivers/md/dm-bufio.c =================================================================== --- linux-2.6-compile.orig/drivers/md/dm-bufio.c 2011-11-07 16:31:34.000000000 +0100 +++ linux-2.6-compile/drivers/md/dm-bufio.c 2011-11-07 16:31:41.000000000 +0100 @@ -8,6 +8,7 @@ #include "dm-bufio.h" +#include <linux/module.h> #include <linux/device-mapper.h> #include <linux/dm-io.h> #include <linux/slab.h> Mikulas ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dm-devel] Error when compiling drivers/md/dm-bufio.c 2011-11-07 15:36 ` Mikulas Patocka @ 2011-11-07 16:15 ` Witold Baryluk 2011-11-07 16:20 ` Alasdair G Kergon 2011-11-07 16:18 ` Linus Torvalds 1 sibling, 1 reply; 10+ messages in thread From: Witold Baryluk @ 2011-11-07 16:15 UTC (permalink / raw) To: Mikulas Patocka Cc: Linus Torvalds, Alasdair G Kergon, Neil Brown, linux-raid, dm-devel On 11-07 10:36, Mikulas Patocka wrote: > > > On Mon, 7 Nov 2011, Alasdair G Kergon wrote: > > > On Mon, Nov 07, 2011 at 09:22:31AM +0100, Witold Baryluk wrote: > > > I just got error on todays Linus' tree > > > CC [M] drivers/md/dm-bufio.o > > > drivers/md/dm-bufio.c:988:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] > > > > Probably related to this merge: > > commit 32aaeffbd4a7457bf2f7448b33b5946ff2a960eb > > Merge branch 'modsplit-Oct31_2011' of git://git.kernel.org/pub/scm/linux/ker > > > > Previously module.h was included via another header file. > > Now, bufio.c needs an explicit > > > > #include <linux/module.h> > > > > Alasdair > > > > Yes, apply this patch: > > dm-bufio: Include <linux/module.h> > > Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> > > --- > drivers/md/dm-bufio.c | 1 + > 1 file changed, 1 insertion(+) > > Index: linux-2.6-compile/drivers/md/dm-bufio.c > =================================================================== > --- linux-2.6-compile.orig/drivers/md/dm-bufio.c 2011-11-07 16:31:34.000000000 +0100 > +++ linux-2.6-compile/drivers/md/dm-bufio.c 2011-11-07 16:31:41.000000000 +0100 > @@ -8,6 +8,7 @@ > > #include "dm-bufio.h" > > +#include <linux/module.h> > #include <linux/device-mapper.h> > #include <linux/dm-io.h> > #include <linux/slab.h> > > Mikulas Compiles. However, I get similar warnings (not errors this times, because only variables are used probably, and implicitly used as ints) CC [M] drivers/md/persistent-data/dm-space-map-checker.o drivers/md/persistent-data/dm-space-map-checker.c:427:1: warning: data definition has no type or storage class [enabled by default] drivers/md/persistent-data/dm-space-map-checker.c:427:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/persistent-data/dm-space-map-checker.c:427:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/persistent-data/dm-space-map-checker.c:433:1: warning: data definition has no type or storage class [enabled by default] drivers/md/persistent-data/dm-space-map-checker.c:433:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’ [-Wimplicit-int] drivers/md/persistent-data/dm-space-map-checker.c:433:1: warning: parameter names (without types) in function declaration [enabled by default] CC [M] drivers/md/persistent-data/dm-space-map-common.o Adding similar include to dm-space-map-checker.c, resolves problem. No further problems found (however I do not have all CONFIG_DM_* enabled). Regards, Witek -- Witold Baryluk JID: witold.baryluk // jabster.pl -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dm-devel] Error when compiling drivers/md/dm-bufio.c 2011-11-07 16:15 ` Witold Baryluk @ 2011-11-07 16:20 ` Alasdair G Kergon 0 siblings, 0 replies; 10+ messages in thread From: Alasdair G Kergon @ 2011-11-07 16:20 UTC (permalink / raw) To: Witold Baryluk Cc: Mikulas Patocka, Linus Torvalds, Alasdair G Kergon, Neil Brown, linux-raid, dm-devel On Mon, Nov 07, 2011 at 05:15:14PM +0100, Witold Baryluk wrote: > Adding similar include to dm-space-map-checker.c, resolves problem. In there, try the new #include <linux/export.h> Alasdair ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dm-devel] Error when compiling drivers/md/dm-bufio.c 2011-11-07 15:36 ` Mikulas Patocka 2011-11-07 16:15 ` Witold Baryluk @ 2011-11-07 16:18 ` Linus Torvalds 2011-11-07 16:23 ` Mikulas Patocka 2011-11-07 16:32 ` Witold Baryluk 1 sibling, 2 replies; 10+ messages in thread From: Linus Torvalds @ 2011-11-07 16:18 UTC (permalink / raw) To: Mikulas Patocka Cc: Witold Baryluk, Alasdair G Kergon, Neil Brown, linux-raid, dm-devel On Mon, Nov 7, 2011 at 7:36 AM, Mikulas Patocka <mpatocka@redhat.com> wrote: > > Yes, apply this patch: > > dm-bufio: Include <linux/module.h> Actually, is just <linux/export.h> sufficient? It's much better to use just export.h if you have the choice - lots of code doesn't need the whole module thing that brings in just about all the headers in the whole kernel (ok, not quite, but still..) That was kind of the whole point of the split. Linus ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dm-devel] Error when compiling drivers/md/dm-bufio.c 2011-11-07 16:18 ` Linus Torvalds @ 2011-11-07 16:23 ` Mikulas Patocka 2011-11-07 16:32 ` Witold Baryluk 1 sibling, 0 replies; 10+ messages in thread From: Mikulas Patocka @ 2011-11-07 16:23 UTC (permalink / raw) To: Linus Torvalds Cc: Witold Baryluk, Alasdair G Kergon, Neil Brown, linux-raid, dm-devel On Mon, 7 Nov 2011, Linus Torvalds wrote: > On Mon, Nov 7, 2011 at 7:36 AM, Mikulas Patocka <mpatocka@redhat.com> wrote: > > > > Yes, apply this patch: > > > > dm-bufio: Include <linux/module.h> > > Actually, is just <linux/export.h> sufficient? > > It's much better to use just export.h if you have the choice - lots of > code doesn't need the whole module thing that brings in just about all > the headers in the whole kernel (ok, not quite, but still..) > > That was kind of the whole point of the split. > > Linus No, with <linux/export.h> included, it fails when compiling "module_param_named" macro. Mikulas ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dm-devel] Error when compiling drivers/md/dm-bufio.c 2011-11-07 16:18 ` Linus Torvalds 2011-11-07 16:23 ` Mikulas Patocka @ 2011-11-07 16:32 ` Witold Baryluk 2011-11-07 19:00 ` Alasdair G Kergon 1 sibling, 1 reply; 10+ messages in thread From: Witold Baryluk @ 2011-11-07 16:32 UTC (permalink / raw) To: Linus Torvalds Cc: Mikulas Patocka, Alasdair G Kergon, Neil Brown, linux-raid, dm-devel [-- Attachment #1: Type: text/plain, Size: 2318 bytes --] On 11-07 08:18, Linus Torvalds wrote: > On Mon, Nov 7, 2011 at 7:36 AM, Mikulas Patocka <mpatocka@redhat.com> wrote: > > > > Yes, apply this patch: > > > > dm-bufio: Include <linux/module.h> > > Actually, is just <linux/export.h> sufficient? I changed include to <linux/export.h>, and dm-bufio.c gives error CC [M] drivers/md/dm-bufio.o drivers/md/dm-bufio.c:1677:63: error: expected ‘)’ before ‘ulong’ drivers/md/dm-bufio.c:1678:40: error: expected ‘)’ before string constant drivers/md/dm-bufio.c:1680:55: error: expected ‘)’ before ‘uint’ drivers/md/dm-bufio.c:1681:35: error: expected ‘)’ before string constant drivers/md/dm-bufio.c:1683:67: error: expected ‘)’ before ‘ulong’ drivers/md/dm-bufio.c:1684:40: error: expected ‘)’ before string constant drivers/md/dm-bufio.c:1686:79: error: expected ‘)’ before ‘ulong’ drivers/md/dm-bufio.c:1687:46: error: expected ‘)’ before string constant drivers/md/dm-bufio.c:1689:87: error: expected ‘)’ before ‘ulong’ drivers/md/dm-bufio.c:1690:50: error: expected ‘)’ before string constant drivers/md/dm-bufio.c:1692:73: error: expected ‘)’ before ‘ulong’ drivers/md/dm-bufio.c:1693:43: error: expected ‘)’ before string constant drivers/md/dm-bufio.c:1695:73: error: expected ‘)’ before ‘ulong’ drivers/md/dm-bufio.c:1696:43: error: expected ‘)’ before string constant drivers/md/dm-bufio.c:1698:15: error: expected declaration specifiers or ‘...’ before string constant drivers/md/dm-bufio.c:1699:20: error: expected declaration specifiers or ‘...’ before string constant drivers/md/dm-bufio.c:1700:16: error: expected declaration specifiers or ‘...’ before string constant It is using module_param_named, and MODULE_PARAM_DESC, MODULE_AUTHOR, MODULE_DESCRIPTION, MODULE_LICENSE macros. (and module_init() and module_exit() also). However dm-space-map-checker.c compiles fine. Update patch atached. > > It's much better to use just export.h if you have the choice - lots of > code doesn't need the whole module thing that brings in just about all > the headers in the whole kernel (ok, not quite, but still..) > > That was kind of the whole point of the split. > > Linus Regards, Witek -- Witold Baryluk JID: witold.baryluk // jabster.pl [-- Attachment #2: driver-md-include-module-h-export-h.patch --] [-- Type: text/x-diff, Size: 710 bytes --] diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c index cb24666..4ef8116 100644 --- a/drivers/md/dm-bufio.c +++ b/drivers/md/dm-bufio.c @@ -8,6 +8,7 @@ #include "dm-bufio.h" +#include <linux/module.h> #include <linux/device-mapper.h> #include <linux/dm-io.h> #include <linux/slab.h> diff --git a/drivers/md/persistent-data/dm-space-map-checker.c b/drivers/md/persistent-data/dm-space-map-checker.c index bb44a93..4bbc7d5 100644 --- a/drivers/md/persistent-data/dm-space-map-checker.c +++ b/drivers/md/persistent-data/dm-space-map-checker.c @@ -6,6 +6,7 @@ #include "dm-space-map-checker.h" +#include <linux/export.h> #include <linux/device-mapper.h> #ifdef CONFIG_DM_DEBUG_SPACE_MAPS ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: Error when compiling drivers/md/dm-bufio.c 2011-11-07 16:32 ` Witold Baryluk @ 2011-11-07 19:00 ` Alasdair G Kergon 2011-11-07 20:27 ` [dm-devel] " Witold Baryluk 0 siblings, 1 reply; 10+ messages in thread From: Alasdair G Kergon @ 2011-11-07 19:00 UTC (permalink / raw) To: Witold Baryluk Cc: linux-raid, dm-devel, Mikulas Patocka, Linus Torvalds, Alasdair G Kergon On Mon, Nov 07, 2011 at 05:32:15PM +0100, Witold Baryluk wrote: > Update patch atached. More module.h files can now be export.h I think, so try this version: http://git.kernel.org/?p=linux/kernel/git/agk/linux-dm.git;a=patch;h=bef30d3d2059b80b8994ad6a9db8612518ea7a10 commit bef30d3d2059b80b8994ad6a9db8612518ea7a10 Author: Alasdair G Kergon <agk@redhat.com> Date: Mon Nov 7 18:45:18 2011 +0000 dm: fix module export includes Fix the use of export.h and module.h in new thin provisioning code. Signed-off-by: Alasdair G Kergon <agk@redhat.com> diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c index cb24666..6919d50 100644 --- a/drivers/md/dm-bufio.c +++ b/drivers/md/dm-bufio.c @@ -10,6 +10,7 @@ #include <linux/device-mapper.h> #include <linux/dm-io.h> +#include <linux/module.h> #include <linux/slab.h> #include <linux/vmalloc.h> #include <linux/version.h> diff --git a/drivers/md/persistent-data/dm-btree-remove.c b/drivers/md/persistent-data/dm-btree-remove.c index 65fd85e..023fbc2 100644 --- a/drivers/md/persistent-data/dm-btree-remove.c +++ b/drivers/md/persistent-data/dm-btree-remove.c @@ -8,7 +8,7 @@ #include "dm-btree-internal.h" #include "dm-transaction-manager.h" -#include <linux/module.h> +#include <linux/export.h> /* * Removing an entry from a btree diff --git a/drivers/md/persistent-data/dm-btree.c b/drivers/md/persistent-data/dm-btree.c index e0638be..bd1e7ff 100644 --- a/drivers/md/persistent-data/dm-btree.c +++ b/drivers/md/persistent-data/dm-btree.c @@ -8,7 +8,7 @@ #include "dm-space-map.h" #include "dm-transaction-manager.h" -#include <linux/module.h> +#include <linux/export.h> #include <linux/device-mapper.h> #define DM_MSG_PREFIX "btree" diff --git a/drivers/md/persistent-data/dm-space-map-checker.c b/drivers/md/persistent-data/dm-space-map-checker.c index bb44a93..4bbc7d5 100644 --- a/drivers/md/persistent-data/dm-space-map-checker.c +++ b/drivers/md/persistent-data/dm-space-map-checker.c @@ -6,6 +6,7 @@ #include "dm-space-map-checker.h" +#include <linux/export.h> #include <linux/device-mapper.h> #ifdef CONFIG_DM_DEBUG_SPACE_MAPS diff --git a/drivers/md/persistent-data/dm-space-map-disk.c b/drivers/md/persistent-data/dm-space-map-disk.c index aeff785..fc469ba 100644 --- a/drivers/md/persistent-data/dm-space-map-disk.c +++ b/drivers/md/persistent-data/dm-space-map-disk.c @@ -12,7 +12,7 @@ #include <linux/list.h> #include <linux/slab.h> -#include <linux/module.h> +#include <linux/export.h> #include <linux/device-mapper.h> #define DM_MSG_PREFIX "space map disk" diff --git a/drivers/md/persistent-data/dm-transaction-manager.c b/drivers/md/persistent-data/dm-transaction-manager.c index 728e89a..6f8d387 100644 --- a/drivers/md/persistent-data/dm-transaction-manager.c +++ b/drivers/md/persistent-data/dm-transaction-manager.c @@ -10,7 +10,7 @@ #include "dm-space-map-metadata.h" #include "dm-persistent-data-internal.h" -#include <linux/module.h> +#include <linux/export.h> #include <linux/slab.h> #include <linux/device-mapper.h> ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [dm-devel] Error when compiling drivers/md/dm-bufio.c 2011-11-07 19:00 ` Alasdair G Kergon @ 2011-11-07 20:27 ` Witold Baryluk 0 siblings, 0 replies; 10+ messages in thread From: Witold Baryluk @ 2011-11-07 20:27 UTC (permalink / raw) To: Linus Torvalds, Mikulas Patocka, Alasdair G Kergon, Neil Brown, linux-raid, dm- On 11-07 19:00, Alasdair G Kergon wrote: > On Mon, Nov 07, 2011 at 05:32:15PM +0100, Witold Baryluk wrote: > > Update patch atached. > > More module.h files can now be export.h I think, so try this version: > http://git.kernel.org/?p=linux/kernel/git/agk/linux-dm.git;a=patch;h=bef30d3d2059b80b8994ad6a9db8612518ea7a10 > > commit bef30d3d2059b80b8994ad6a9db8612518ea7a10 > Author: Alasdair G Kergon <agk@redhat.com> > Date: Mon Nov 7 18:45:18 2011 +0000 > > dm: fix module export includes > > Fix the use of export.h and module.h in new thin provisioning code. > > Signed-off-by: Alasdair G Kergon <agk@redhat.com> > > diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c > index cb24666..6919d50 100644 > --- a/drivers/md/dm-bufio.c > +++ b/drivers/md/dm-bufio.c > @@ -10,6 +10,7 @@ > > #include <linux/device-mapper.h> > #include <linux/dm-io.h> > +#include <linux/module.h> > #include <linux/slab.h> > #include <linux/vmalloc.h> > #include <linux/version.h> > diff --git a/drivers/md/persistent-data/dm-btree-remove.c b/drivers/md/persistent-data/dm-btree-remove.c > index 65fd85e..023fbc2 100644 > --- a/drivers/md/persistent-data/dm-btree-remove.c > +++ b/drivers/md/persistent-data/dm-btree-remove.c > @@ -8,7 +8,7 @@ > #include "dm-btree-internal.h" > #include "dm-transaction-manager.h" > > -#include <linux/module.h> > +#include <linux/export.h> > > /* > * Removing an entry from a btree > diff --git a/drivers/md/persistent-data/dm-btree.c b/drivers/md/persistent-data/dm-btree.c > index e0638be..bd1e7ff 100644 > --- a/drivers/md/persistent-data/dm-btree.c > +++ b/drivers/md/persistent-data/dm-btree.c > @@ -8,7 +8,7 @@ > #include "dm-space-map.h" > #include "dm-transaction-manager.h" > > -#include <linux/module.h> > +#include <linux/export.h> > #include <linux/device-mapper.h> > > #define DM_MSG_PREFIX "btree" > diff --git a/drivers/md/persistent-data/dm-space-map-checker.c b/drivers/md/persistent-data/dm-space-map-checker.c > index bb44a93..4bbc7d5 100644 > --- a/drivers/md/persistent-data/dm-space-map-checker.c > +++ b/drivers/md/persistent-data/dm-space-map-checker.c > @@ -6,6 +6,7 @@ > > #include "dm-space-map-checker.h" > > +#include <linux/export.h> > #include <linux/device-mapper.h> > > #ifdef CONFIG_DM_DEBUG_SPACE_MAPS > diff --git a/drivers/md/persistent-data/dm-space-map-disk.c b/drivers/md/persistent-data/dm-space-map-disk.c > index aeff785..fc469ba 100644 > --- a/drivers/md/persistent-data/dm-space-map-disk.c > +++ b/drivers/md/persistent-data/dm-space-map-disk.c > @@ -12,7 +12,7 @@ > > #include <linux/list.h> > #include <linux/slab.h> > -#include <linux/module.h> > +#include <linux/export.h> > #include <linux/device-mapper.h> > > #define DM_MSG_PREFIX "space map disk" > diff --git a/drivers/md/persistent-data/dm-transaction-manager.c b/drivers/md/persistent-data/dm-transaction-manager.c > index 728e89a..6f8d387 100644 > --- a/drivers/md/persistent-data/dm-transaction-manager.c > +++ b/drivers/md/persistent-data/dm-transaction-manager.c > @@ -10,7 +10,7 @@ > #include "dm-space-map-metadata.h" > #include "dm-persistent-data-internal.h" > > -#include <linux/module.h> > +#include <linux/export.h> > #include <linux/slab.h> > #include <linux/device-mapper.h> > All files affected by patch compiles cleanly. Tested-by: Witold Baryluk <baryluk@smp.if.uj.edu.pl> Thanks. -- Witold Baryluk ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-11-07 20:27 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-11-07 8:22 Error when compiling drivers/md/dm-bufio.c Witold Baryluk 2011-11-07 13:46 ` [dm-devel] " Alasdair G Kergon 2011-11-07 15:36 ` Mikulas Patocka 2011-11-07 16:15 ` Witold Baryluk 2011-11-07 16:20 ` Alasdair G Kergon 2011-11-07 16:18 ` Linus Torvalds 2011-11-07 16:23 ` Mikulas Patocka 2011-11-07 16:32 ` Witold Baryluk 2011-11-07 19:00 ` Alasdair G Kergon 2011-11-07 20:27 ` [dm-devel] " Witold Baryluk
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).