From: Dan Carpenter <dan.carpenter@oracle.com>
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org
Subject: re: md/raid10: handle recovery of replacement devices.
Date: Tue, 15 Nov 2011 09:32:39 +0300 [thread overview]
Message-ID: <20111115063239.GA30827@elgon.mountain> (raw)
Hello NeilBrown,
This is a semi-automatic email about new static checker warnings.
The patch e1f6cbf7e1b0: "md/raid10: handle recovery of replacement
devices." from Nov 9, 2011, leads to the following Smatch complaint:
drivers/md/raid10.c +2814 sync_request()
error: we previously assumed 'bio' could be null (see line 2808)
drivers/md/raid10.c
2807 bio = r10_bio->devs[1].repl_bio;
2808 if (bio)
^^^
check.
2809 bio->bi_end_io = NULL;
2810 rdev = mirror->replacement;
2811 if (rdev == NULL ||
2812 test_bit(Faulty, &rdev->flags))
2813 break;
2814 bio->bi_next = biolist;
^^^^^^^^^^^^
unconditional dereference.
2815 biolist = bio;
2816 bio->bi_private = r10_bio;
regards,
dan carpenter
next reply other threads:[~2011-11-15 6:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 6:32 Dan Carpenter [this message]
2011-11-15 6:58 ` md/raid10: handle recovery of replacement devices NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111115063239.GA30827@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox