* [PATCH] fix: correct metadata's update communication
@ 2011-11-18 14:34 Lukasz Dorau
2011-11-21 5:19 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: Lukasz Dorau @ 2011-11-18 14:34 UTC (permalink / raw)
To: neilb; +Cc: linux-raid, dan.j.williams, marcin.labun, ed.ciechanowski
The problem occurs when array under migration is assembled incrementally.
st->update_tail is not initialized in function
assemble_container_content() and during reshape
the checkpoint information in metadata is not being updated.
The value of st->update_tail is now initialized in function
assemble_container_content() and during reshape the checkpoint
information in metadata is being updated correctly on all disks.
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
---
Assemble.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/Assemble.c b/Assemble.c
index 3c8e74d..74708d1 100644
--- a/Assemble.c
+++ b/Assemble.c
@@ -1585,6 +1585,9 @@ int assemble_container_content(struct supertype *st, int mdfd,
if (!mdmon_running(st->container_dev))
start_mdmon(st->container_dev);
ping_monitor_by_id(st->container_dev);
+ if (mdmon_running(st->container_dev) &&
+ st->update_tail == NULL)
+ st->update_tail = &st->updates;
}
err = Grow_continue(mdfd, st, content, backup_file,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fix: correct metadata's update communication
2011-11-18 14:34 [PATCH] fix: correct metadata's update communication Lukasz Dorau
@ 2011-11-21 5:19 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2011-11-21 5:19 UTC (permalink / raw)
To: Lukasz Dorau; +Cc: linux-raid, dan.j.williams, marcin.labun, ed.ciechanowski
[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]
On Fri, 18 Nov 2011 15:34:33 +0100 Lukasz Dorau <lukasz.dorau@intel.com>
wrote:
> The problem occurs when array under migration is assembled incrementally.
> st->update_tail is not initialized in function
> assemble_container_content() and during reshape
> the checkpoint information in metadata is not being updated.
>
> The value of st->update_tail is now initialized in function
> assemble_container_content() and during reshape the checkpoint
> information in metadata is being updated correctly on all disks.
>
> Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
> ---
> Assemble.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/Assemble.c b/Assemble.c
> index 3c8e74d..74708d1 100644
> --- a/Assemble.c
> +++ b/Assemble.c
> @@ -1585,6 +1585,9 @@ int assemble_container_content(struct supertype *st, int mdfd,
> if (!mdmon_running(st->container_dev))
> start_mdmon(st->container_dev);
> ping_monitor_by_id(st->container_dev);
> + if (mdmon_running(st->container_dev) &&
> + st->update_tail == NULL)
> + st->update_tail = &st->updates;
> }
>
> err = Grow_continue(mdfd, st, content, backup_file,
This and the previous patch ( [PATCH] imsm: fix: correct printing value of
blocks per migration unit) applied - thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-21 5:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-18 14:34 [PATCH] fix: correct metadata's update communication Lukasz Dorau
2011-11-21 5:19 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).