Re: [PATCH] imsm: incorrect incremental behavior because of wrong index used

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]

On Wed, 23 Nov 2011 10:56:21 -0800 "Williams, Dan J"
<dan.j.williams@intel.com> wrote:

> On Wed, Nov 23, 2011 at 8:59 AM, Przemyslaw Czarnowski
> <przemyslaw.hawrylewicz.czarnowski@intel.com> wrote:
> > Incremental in some cases prematurely assembles degraded arrays due to
> > wrong index used in code which counts missing disks
> >
> > Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com>
> 
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> 
> > ---
> >  super-intel.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/super-intel.c b/super-intel.c
> > index 360c4cc..a0672bf 100644
> > --- a/super-intel.c
> > +++ b/super-intel.c
> > @@ -2539,7 +2539,7 @@ static void getinfo_super_imsm(struct supertype *st, struct mdinfo *info, char *
> >                 * (catches single-degraded vs double-degraded)
> >                 */
> >                for (j = 0; j < map->num_members; j++) {
> > -                       __u32 ord = get_imsm_ord_tbl_ent(dev, i, 0);
> > +                       __u32 ord = get_imsm_ord_tbl_ent(dev, j, 0);
> >                        __u32 idx = ord_to_idx(ord);
> >
> >                        if (!(ord & IMSM_ORD_REBUILD) &&
> >
> >


Applied, thanks.

NeilBrown


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]