* [PATCH] imsm: incorrect incremental behavior because of wrong index used
@ 2011-11-23 16:59 Przemyslaw Czarnowski
2011-11-23 18:56 ` Williams, Dan J
0 siblings, 1 reply; 3+ messages in thread
From: Przemyslaw Czarnowski @ 2011-11-23 16:59 UTC (permalink / raw)
To: neilb; +Cc: linux-raid, dan.j.williams, marcin.labun, ed.ciechanowski
Incremental in some cases prematurely assembles degraded arrays due to
wrong index used in code which counts missing disks
Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com>
---
super-intel.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/super-intel.c b/super-intel.c
index 360c4cc..a0672bf 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -2539,7 +2539,7 @@ static void getinfo_super_imsm(struct supertype *st, struct mdinfo *info, char *
* (catches single-degraded vs double-degraded)
*/
for (j = 0; j < map->num_members; j++) {
- __u32 ord = get_imsm_ord_tbl_ent(dev, i, 0);
+ __u32 ord = get_imsm_ord_tbl_ent(dev, j, 0);
__u32 idx = ord_to_idx(ord);
if (!(ord & IMSM_ORD_REBUILD) &&
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] imsm: incorrect incremental behavior because of wrong index used
2011-11-23 16:59 [PATCH] imsm: incorrect incremental behavior because of wrong index used Przemyslaw Czarnowski
@ 2011-11-23 18:56 ` Williams, Dan J
2011-11-24 5:23 ` NeilBrown
0 siblings, 1 reply; 3+ messages in thread
From: Williams, Dan J @ 2011-11-23 18:56 UTC (permalink / raw)
To: Przemyslaw Czarnowski
Cc: neilb, linux-raid, marcin.labun, ed.ciechanowski, Doug Ledford
On Wed, Nov 23, 2011 at 8:59 AM, Przemyslaw Czarnowski
<przemyslaw.hawrylewicz.czarnowski@intel.com> wrote:
> Incremental in some cases prematurely assembles degraded arrays due to
> wrong index used in code which counts missing disks
>
> Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> ---
> super-intel.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index 360c4cc..a0672bf 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -2539,7 +2539,7 @@ static void getinfo_super_imsm(struct supertype *st, struct mdinfo *info, char *
> * (catches single-degraded vs double-degraded)
> */
> for (j = 0; j < map->num_members; j++) {
> - __u32 ord = get_imsm_ord_tbl_ent(dev, i, 0);
> + __u32 ord = get_imsm_ord_tbl_ent(dev, j, 0);
> __u32 idx = ord_to_idx(ord);
>
> if (!(ord & IMSM_ORD_REBUILD) &&
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] imsm: incorrect incremental behavior because of wrong index used
2011-11-23 18:56 ` Williams, Dan J
@ 2011-11-24 5:23 ` NeilBrown
0 siblings, 0 replies; 3+ messages in thread
From: NeilBrown @ 2011-11-24 5:23 UTC (permalink / raw)
To: Williams, Dan J
Cc: Przemyslaw Czarnowski, linux-raid, marcin.labun, ed.ciechanowski,
Doug Ledford
[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]
On Wed, 23 Nov 2011 10:56:21 -0800 "Williams, Dan J"
<dan.j.williams@intel.com> wrote:
> On Wed, Nov 23, 2011 at 8:59 AM, Przemyslaw Czarnowski
> <przemyslaw.hawrylewicz.czarnowski@intel.com> wrote:
> > Incremental in some cases prematurely assembles degraded arrays due to
> > wrong index used in code which counts missing disks
> >
> > Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com>
>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
>
> > ---
> > super-intel.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/super-intel.c b/super-intel.c
> > index 360c4cc..a0672bf 100644
> > --- a/super-intel.c
> > +++ b/super-intel.c
> > @@ -2539,7 +2539,7 @@ static void getinfo_super_imsm(struct supertype *st, struct mdinfo *info, char *
> > * (catches single-degraded vs double-degraded)
> > */
> > for (j = 0; j < map->num_members; j++) {
> > - __u32 ord = get_imsm_ord_tbl_ent(dev, i, 0);
> > + __u32 ord = get_imsm_ord_tbl_ent(dev, j, 0);
> > __u32 idx = ord_to_idx(ord);
> >
> > if (!(ord & IMSM_ORD_REBUILD) &&
> >
> >
Applied, thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-24 5:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-23 16:59 [PATCH] imsm: incorrect incremental behavior because of wrong index used Przemyslaw Czarnowski
2011-11-23 18:56 ` Williams, Dan J
2011-11-24 5:23 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).