[PATCH] imsm: FIX: Just created redundant array is not in uninitialized state

[PATCH] imsm: FIX: Just created redundant array is not in uninitialized state

[Adam Kwolek]

When redundant array (e.g. raid5) is created metadata shows it is in
normal state. Initialization process is showed in metadata as rebuild from normal
to normal state. Redundant array should be initially in uninitialized state
before it's initialization.

Add code to put array in uninitialized state upon array creation.

Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
---

 super-intel.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/super-intel.c b/super-intel.c
index a0672bf..b8abea0 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -4289,7 +4289,11 @@ static int init_super_imsm_volume(struct supertype *st, mdu_array_info_t *info,
 	map->blocks_per_member = __cpu_to_le32(info_to_blocks_per_member(info));
 	map->blocks_per_strip = __cpu_to_le16(info_to_blocks_per_strip(info));
 	map->failed_disk_num = ~0;
-	map->map_state = info->failed_disks ? IMSM_T_STATE_DEGRADED : IMSM_T_STATE_NORMAL;
+	if (info->level > 0)
+		map->map_state = IMSM_T_STATE_UNINITIALIZED;
+	else
+		map->map_state = info->failed_disks ? IMSM_T_STATE_FAILED :
+						      IMSM_T_STATE_NORMAL;
 	map->ddf = 1;
 
 	if (info->level == 1 && info->raid_disks > 2) {

Re: [PATCH] imsm: FIX: Just created redundant array is not in uninitialized state

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 1386 bytes --]

On Mon, 05 Dec 2011 09:26:52 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:

> When redundant array (e.g. raid5) is created metadata shows it is in
> normal state. Initialization process is showed in metadata as rebuild from normal
> to normal state. Redundant array should be initially in uninitialized state
> before it's initialization.
> 
> Add code to put array in uninitialized state upon array creation.
> 
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
> 
>  super-intel.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/super-intel.c b/super-intel.c
> index a0672bf..b8abea0 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -4289,7 +4289,11 @@ static int init_super_imsm_volume(struct supertype *st, mdu_array_info_t *info,
>  	map->blocks_per_member = __cpu_to_le32(info_to_blocks_per_member(info));
>  	map->blocks_per_strip = __cpu_to_le16(info_to_blocks_per_strip(info));
>  	map->failed_disk_num = ~0;
> -	map->map_state = info->failed_disks ? IMSM_T_STATE_DEGRADED : IMSM_T_STATE_NORMAL;
> +	if (info->level > 0)
> +		map->map_state = IMSM_T_STATE_UNINITIALIZED;
> +	else
> +		map->map_state = info->failed_disks ? IMSM_T_STATE_FAILED :
> +						      IMSM_T_STATE_NORMAL;
>  	map->ddf = 1;
>  
>  	if (info->level == 1 && info->raid_disks > 2) {

Applied, thanks.

NeilBrown


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]