* Re: ext4 data=writeback performs worse than data=ordered now [not found] ` <1323910977.22361.423.camel@sli10-conroe> @ 2011-12-15 1:00 ` Wu Fengguang 2011-12-15 1:27 ` NeilBrown 0 siblings, 1 reply; 4+ messages in thread From: Wu Fengguang @ 2011-12-15 1:00 UTC (permalink / raw) To: Li, Shaohua Cc: Ted Ts'o, linux-ext4@vger.kernel.org, Jan Kara, LKML, linux-fsdevel@vger.kernel.org, NeilBrown, linux-raid, Jens Axboe > I found sometimes one disk hasn't any request inflight, but we can't > send request to the disk, because the scsi host's resource (the queue > depth) is used out, looks we send too many requests from other disks and > leave some disks starved. The resource imbalance in scsi isn't a new > problem, even 3.1 has such issue, so I'd think writeback introduces new > imbalance between the 12 disks. In fact, if I limit disk's queue depth > to 10, in this way the 12 disks will not impact each other in scsi > layer, the performance regression fully disappears for both writeback > and order mode. I observe similar issue in MD. The default q->nr_requests = BLKDEV_MAX_RQ; is too small for large arrays, and I end up doing echo 1280 > /sys/block/md0/queue/nr_requests in my tests. Thanks, Fengguang ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ext4 data=writeback performs worse than data=ordered now 2011-12-15 1:00 ` ext4 data=writeback performs worse than data=ordered now Wu Fengguang @ 2011-12-15 1:27 ` NeilBrown 2011-12-15 1:34 ` Wu Fengguang 2011-12-15 5:02 ` Wu Fengguang 0 siblings, 2 replies; 4+ messages in thread From: NeilBrown @ 2011-12-15 1:27 UTC (permalink / raw) To: Wu Fengguang Cc: Li, Shaohua, Ted Ts'o, linux-ext4@vger.kernel.org, Jan Kara, LKML, linux-fsdevel@vger.kernel.org, linux-raid, Jens Axboe [-- Attachment #1: Type: text/plain, Size: 1142 bytes --] On Thu, 15 Dec 2011 09:00:10 +0800 Wu Fengguang <fengguang.wu@intel.com> wrote: > > I found sometimes one disk hasn't any request inflight, but we can't > > send request to the disk, because the scsi host's resource (the queue > > depth) is used out, looks we send too many requests from other disks and > > leave some disks starved. The resource imbalance in scsi isn't a new > > problem, even 3.1 has such issue, so I'd think writeback introduces new > > imbalance between the 12 disks. In fact, if I limit disk's queue depth > > to 10, in this way the 12 disks will not impact each other in scsi > > layer, the performance regression fully disappears for both writeback > > and order mode. > > I observe similar issue in MD. The default > > q->nr_requests = BLKDEV_MAX_RQ; > > is too small for large arrays, and I end up doing > > echo 1280 > /sys/block/md0/queue/nr_requests > > in my tests. And you find this makes a difference? That is very surprising because md devices don't use requests (and really use the 'queue' at all) and definitely don't make use of nr_requests. NeilBrown [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 828 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ext4 data=writeback performs worse than data=ordered now 2011-12-15 1:27 ` NeilBrown @ 2011-12-15 1:34 ` Wu Fengguang 2011-12-15 5:02 ` Wu Fengguang 1 sibling, 0 replies; 4+ messages in thread From: Wu Fengguang @ 2011-12-15 1:34 UTC (permalink / raw) To: NeilBrown Cc: Li, Shaohua, Ted Ts'o, linux-ext4@vger.kernel.org, Jan Kara, LKML, linux-fsdevel@vger.kernel.org, linux-raid@vger.kernel.org, Jens Axboe On Thu, Dec 15, 2011 at 09:27:59AM +0800, NeilBrown wrote: > On Thu, 15 Dec 2011 09:00:10 +0800 Wu Fengguang <fengguang.wu@intel.com> > wrote: > > > > I found sometimes one disk hasn't any request inflight, but we can't > > > send request to the disk, because the scsi host's resource (the queue > > > depth) is used out, looks we send too many requests from other disks and > > > leave some disks starved. The resource imbalance in scsi isn't a new > > > problem, even 3.1 has such issue, so I'd think writeback introduces new > > > imbalance between the 12 disks. In fact, if I limit disk's queue depth > > > to 10, in this way the 12 disks will not impact each other in scsi > > > layer, the performance regression fully disappears for both writeback > > > and order mode. > > > > I observe similar issue in MD. The default > > > > q->nr_requests = BLKDEV_MAX_RQ; > > > > is too small for large arrays, and I end up doing > > > > echo 1280 > /sys/block/md0/queue/nr_requests > > > > in my tests. > > And you find this makes a difference? > > That is very surprising because md devices don't use requests (and really use > the 'queue' at all) and definitely don't make use of nr_requests. Ah OK. Hope that I was wrong. I've just kicked off the tests to make sure. Thanks, Fengguang ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ext4 data=writeback performs worse than data=ordered now 2011-12-15 1:27 ` NeilBrown 2011-12-15 1:34 ` Wu Fengguang @ 2011-12-15 5:02 ` Wu Fengguang 1 sibling, 0 replies; 4+ messages in thread From: Wu Fengguang @ 2011-12-15 5:02 UTC (permalink / raw) To: NeilBrown Cc: Li, Shaohua, Ted Ts'o, linux-ext4@vger.kernel.org, Jan Kara, LKML, linux-fsdevel@vger.kernel.org, linux-raid@vger.kernel.org, Jens Axboe On Thu, Dec 15, 2011 at 09:27:59AM +0800, NeilBrown wrote: > On Thu, 15 Dec 2011 09:00:10 +0800 Wu Fengguang <fengguang.wu@intel.com> > wrote: > > > > I found sometimes one disk hasn't any request inflight, but we can't > > > send request to the disk, because the scsi host's resource (the queue > > > depth) is used out, looks we send too many requests from other disks and > > > leave some disks starved. The resource imbalance in scsi isn't a new > > > problem, even 3.1 has such issue, so I'd think writeback introduces new > > > imbalance between the 12 disks. In fact, if I limit disk's queue depth > > > to 10, in this way the 12 disks will not impact each other in scsi > > > layer, the performance regression fully disappears for both writeback > > > and order mode. > > > > I observe similar issue in MD. The default > > > > q->nr_requests = BLKDEV_MAX_RQ; > > > > is too small for large arrays, and I end up doing > > > > echo 1280 > /sys/block/md0/queue/nr_requests > > > > in my tests. > > And you find this makes a difference? > > That is very surprising because md devices don't use requests (and really use > the 'queue' at all) and definitely don't make use of nr_requests. Yes it is: /sys/block/md0/queue/nr_requests cannot be modified at all... Sorry for the noise! Fengguang ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-15 5:02 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <20111214133400.GA18565@localhost> [not found] ` <20111214143014.GB18080@thunk.org> [not found] ` <1323910977.22361.423.camel@sli10-conroe> 2011-12-15 1:00 ` ext4 data=writeback performs worse than data=ordered now Wu Fengguang 2011-12-15 1:27 ` NeilBrown 2011-12-15 1:34 ` Wu Fengguang 2011-12-15 5:02 ` Wu Fengguang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).