From: NeilBrown <neilb@suse.de>
To: "Kwolek, Adam" <adam.kwolek@intel.com>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"Ciechanowski, Ed" <ed.ciechanowski@intel.com>,
"Labun, Marcin" <Marcin.Labun@intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>
Subject: Re: [PATCH 2/3] imsm: FIX: 'UT 09imsm-assemble' fails
Date: Fri, 16 Dec 2011 06:30:49 +1100 [thread overview]
Message-ID: <20111216063049.6d6422eb@notabene.brown> (raw)
In-Reply-To: <79556383A0E1384DB3A3903742AAC04A0611F8@IRSMSX101.ger.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 356 bytes --]
On Thu, 15 Dec 2011 15:29:50 +0000 "Kwolek, Adam" <adam.kwolek@intel.com>
wrote:
>
> ... what do you think about adding '!' in condition 'if (uuid_set) {'
> It is like your comment in code directs to. With this change test looks ok, but I can miss something this time also ;).
Yes, you are right. I need a '!' in there. Thanks!
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2011-12-15 19:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 15:06 [PATCH 0/3] Enable mdadm UT execution for imsm Adam Kwolek
2011-12-14 15:07 ` [PATCH 1/3] imsm: FIX: Chunk size migration is not possible Adam Kwolek
2011-12-15 4:01 ` NeilBrown
2011-12-14 15:07 ` [PATCH 2/3] imsm: FIX: 'UT 09imsm-assemble' fails Adam Kwolek
2011-12-14 16:27 ` Peter W. Morreale
2011-12-15 4:01 ` NeilBrown
2011-12-15 10:28 ` Kwolek, Adam
2011-12-15 11:07 ` NeilBrown
2011-12-15 15:29 ` Kwolek, Adam
2011-12-15 19:30 ` NeilBrown [this message]
2011-12-14 15:07 ` [PATCH 3/3] imsm: FIX: UT '08imsm-overlap' fails Adam Kwolek
2011-12-14 18:21 ` Williams, Dan J
2011-12-15 4:03 ` NeilBrown
[not found] ` <CABE8wwvfzxM1e2S7XOotMHWT40JF6sbRH3mW688dpuWmwoCtZQ@mail.gmail.com>
2011-12-15 8:01 ` Kwolek, Adam
2011-12-16 4:18 ` Williams, Dan J
2011-12-16 8:32 ` Kwolek, Adam
2011-12-19 23:38 ` NeilBrown
2011-12-20 8:02 ` Kwolek, Adam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111216063049.6d6422eb@notabene.brown \
--to=neilb@suse.de \
--cc=Marcin.Labun@intel.com \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).