Re: [PATCH 0/4] add --initrd argument to mdadm/mdmon

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]

On Tue, 17 Jan 2012 21:16:16 +0100 Jes Sorensen <Jes.Sorensen@redhat.com>
wrote:

> On 01/17/12 20:57, Doug Ledford wrote:
> > Patch set looks reasonable to me, although you missed adding the new
> > option to the mdadm man page.
> > 
> > Do we have a specific systemd version for which we know that --initrd is
> > needed, or a version before which it is the wrong thing to do?
> > 
> > Ditto for dracut, do we know what the minimum version of dracut is
> > before it will use the --initrd parameter on its mdadm calls?
> 
> I actually did this on purpose - or rather I left it out of the help
> message on purpose. The option is really only meant to be used by
> dracut/systemd, it doesn't make much sense for normal users/admins to
> play with it directly.

You left it out of the help message for mdmon, but included it in the help
message for mdadm!

> 
> If you think it makes sense, I can add documentation for it.

I think it should be in the help messages and definitely should be in the man
page.

If you fix that up and the other little things I've identified, then I'll
apply it .... providing we have a name that I can live with.

Thanks,
NeilBrown


> 
> Right now I believe dracut isn't ready to call mdadm with --initrd,
> however systemd in rawhide is aware of the '@' hack. I am not sure of
> the specific version, but we should document the final minimum versions
> once it's all sorted so all distros know which versions to pick.
> 
> Cheers,
> Jes


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]