From: NeilBrown <neilb@suse.de>
To: Jim Meyering <jim@meyering.net>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] avoid double-free upon "old buggy kernel" sysfs_read failure
Date: Wed, 22 Feb 2012 07:14:57 +1100 [thread overview]
Message-ID: <20120222071457.72ec0456@notabene.brown> (raw)
In-Reply-To: <87fwe42vc1.fsf@rho.meyering.net>
[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]
On Tue, 21 Feb 2012 14:02:22 +0100 Jim Meyering <jim@meyering.net> wrote:
> Jim Meyering wrote:
> > * Incremental.c (Incremental): On sysfs_read failure, don't call
> > sysfs_free(sra) just before "goto out_unlock", since that very
> > same "sra" is freed the same way by the clean-up code below.
>
> Here it is again, but with the Signed-off-by line:
>
> >From 981af2b292448a9daa56af86b4c514ad9339665a Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering@redhat.com>
> Date: Tue, 21 Feb 2012 11:08:25 +0100
> Subject: [PATCH] avoid double-free upon "old buggy kernel" sysfs_read failure
>
> * Incremental.c (Incremental): On sysfs_read failure, don't call
> sysfs_free(sra) just before "goto out_unlock", since that very
> same "sra" is freed the same way by the clean-up code below.
>
> Signed-off-by: Jim Meyering <meyering@redhat.com>
> ---
> Incremental.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Incremental.c b/Incremental.c
> index b457bf3..836a6f1 100644
> --- a/Incremental.c
> +++ b/Incremental.c
> @@ -325,7 +325,6 @@ int Incremental(char *devname, int verbose, int runstop,
> fprintf(stderr, Name
> ": You have an old buggy kernel which cannot support\n"
> " --incremental reliably. Aborting.\n");
> - sysfs_free(sra);
> rv = 2;
> goto out_unlock;
> }
> --
> 1.7.9.1.266.g24ee9
> --
Applied, thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2012-02-21 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 11:37 [PATCH] avoid double-free upon "old buggy kernel" sysfs_read failure Jim Meyering
2012-02-21 13:02 ` Jim Meyering
2012-02-21 20:14 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120222071457.72ec0456@notabene.brown \
--to=neilb@suse.de \
--cc=jim@meyering.net \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).