From: NeilBrown <neilb@suse.de>
To: kedacomkernel <kedacomkernel@gmail.com>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: md: Use existed macro instead of number
Date: Mon, 27 Feb 2012 09:57:55 +1100 [thread overview]
Message-ID: <20120227095755.033c450a@notabene.brown> (raw)
In-Reply-To: <201202241500185468624@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1972 bytes --]
On Fri, 24 Feb 2012 15:00:21 +0800 "kedacomkernel" <kedacomkernel@gmail.com>
wrote:
> >From d5905ed3c5355a13e954057856733f8ad64a86ac Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@gmail.com>
> Date: Fri, 24 Feb 2012 22:49:45 +0800
> Subject: [PATCH] md: Use existed macro instead of number
>
>
> Signed-off-by: majianpeng <majianpeng@gmail.com>
> ---
> include/linux/raid/md_p.h | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/raid/md_p.h b/include/linux/raid/md_p.h
> index 6f6df86..7c3577c 100644
> --- a/include/linux/raid/md_p.h
> +++ b/include/linux/raid/md_p.h
> @@ -281,6 +281,8 @@ struct mdp_superblock_1 {
> * active device with same 'role'.
> * 'recovery_offset' is also set.
> */
> -#define MD_FEATURE_ALL (1|2|4|8|16)
> -
> +#define MD_FEATURE_ALL (MD_FEATURE_BITMAP_OFFSET | MD_FEATURE_RECOVERY_OFFSET | \
> + MD_FEATURE_RESHAPE_ACTIVE | MD_FEATURE_BAD_BLOCKS | \
> + MD_FEATURE_REPLACEMENT)
> +
> #endif
Applied, thanks.
Though I reformatted it a bit.
NeilBrown
commit 473a5bfef64c6c328bc110f28ba6c32fe4d4508a
Author: majianpeng <majianpeng@gmail.com>
Date: Mon Feb 27 09:56:59 2012 +1100
md: Use existed macros instead of numbers
Signed-off-by: majianpeng <majianpeng@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
diff --git a/include/linux/raid/md_p.h b/include/linux/raid/md_p.h
index 6f6df86..8c0a3ad 100644
--- a/include/linux/raid/md_p.h
+++ b/include/linux/raid/md_p.h
@@ -281,6 +281,10 @@ struct mdp_superblock_1 {
* active device with same 'role'.
* 'recovery_offset' is also set.
*/
-#define MD_FEATURE_ALL (1|2|4|8|16)
+#define MD_FEATURE_ALL (MD_FEATURE_BITMAP_OFFSET \
+ |MD_FEATURE_RECOVERY_OFFSET \
+ |MD_FEATURE_RESHAPE_ACTIVE \
+ |MD_FEATURE_BAD_BLOCKS \
+ |MD_FEATURE_REPLACEMENT)
#endif
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2012-02-26 22:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 7:00 md: Use existed macro instead of number kedacomkernel
2012-02-26 22:57 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227095755.033c450a@notabene.brown \
--to=neilb@suse.de \
--cc=kedacomkernel@gmail.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).