From: NeilBrown <neilb@suse.de>
To: "J. Ali Harlow" <ali@juiblex.co.uk>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>,
John Robinson <john.robinson@anonymous.org.uk>,
linux-raid@vger.kernel.org
Subject: Re: [PATCH 0/1] Make failure message on re-add more explcit
Date: Mon, 27 Feb 2012 11:01:14 +1100 [thread overview]
Message-ID: <20120227110114.478c0485@notabene.brown> (raw)
In-Reply-To: <1329986847.32304.140661040222909@webmail.messagingengine.com>
[-- Attachment #1: Type: text/plain, Size: 1605 bytes --]
On Thu, 23 Feb 2012 08:47:27 +0000 "J. Ali Harlow" <ali@juiblex.co.uk> wrote:
> On Thu, Feb 23, 2012, at 09:34 AM, Jes Sorensen wrote:
> > On 02/23/12 02:57, John Robinson wrote:
> > > On 22/02/2012 23:16, Jes Sorensen wrote:
> > > [...]
> > >> The goal was to try and reduce the number of bug reports over this by
> > >> making it more obvious/explicit, so if you have a suggestion for how to
> > >> do so in a better way, I am all game.
> > >
> > > How about:
> > >
> > > mdadm /dev/md0 --add %s
> > > : %s was already a member of /dev/md0, attempting re-add
> > > : Re-add failed because <reason>
> > > : Not performing add as that would zero the superblock on %s and make it
> > > a spare
> > > : mdadm --add used to do that automatically but it was potentially
> > > dangerous
> > > : If that is what you really want to do, use mdadm --zero-superblock %s
> > > first.
> > >
> >
> > This would get my vote, way better than my messy attempt.
>
> Would
> : If %s doesn't hold any useful data, use "mdadm --zero-superblock %s"
> before adding.
> be a further refinement?
Maybe .. though "useful" seems a bit of a .... soft(?) word. What exactly
does it mean in this context?
I would probably prefer something like "If you are happy to discard the data
on .....".
And in the earlier suggestion with have "<reason>" which would certainly be
good to have, but filling in the details is not straight forward
unfortunately.
I'm happy to take patches .... they don't have to be perfect, just an
improvement on what we currently have is enough.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2012-02-27 0:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 16:59 [PATCH 0/1] Make failure message on re-add more explcit Jes.Sorensen
2012-02-22 17:00 ` [PATCH 1/1] Make error message on failure to --re-add more explicit Jes.Sorensen
2012-02-22 22:04 ` [PATCH 0/1] Make failure message on re-add more explcit NeilBrown
2012-02-22 23:16 ` Jes Sorensen
2012-02-23 1:57 ` John Robinson
2012-02-23 8:34 ` Jes Sorensen
2012-02-23 8:47 ` J. Ali Harlow
2012-02-27 0:01 ` NeilBrown [this message]
2012-04-05 18:59 ` Doug Ledford
2012-04-09 23:41 ` NeilBrown
2012-04-10 23:44 ` Doug Ledford
2012-04-18 4:25 ` NeilBrown
2012-04-23 19:36 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227110114.478c0485@notabene.brown \
--to=neilb@suse.de \
--cc=Jes.Sorensen@redhat.com \
--cc=ali@juiblex.co.uk \
--cc=john.robinson@anonymous.org.uk \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).