Re: [PATCH] Reset bad flag on map update

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 928 bytes --]

On Wed, 7 Mar 2012 12:51:30 +0000 "Czarnowska, Anna"
<anna.czarnowska@intel.com> wrote:

> Map file may miss an entry if bad flag is not cleared on update.
> 
> This happens for example when an old entry exists in map that
> has no mdstat counterpart and we create a new array with the same devnum.
> Newly created array will not appear in map if update doesnt clear bad flag.
> 
> Signed-off-by: Anna Czarnowska <anna.czarnowska@intel.com>
> ---
>  mapfile.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/mapfile.c b/mapfile.c
> index 0bfecd0..9e2c893 100644
> --- a/mapfile.c
> +++ b/mapfile.c
> @@ -246,6 +246,7 @@ int map_update(struct map_ent **mpp, int devnum, char *metadata,
>  			memcpy(mp->uuid, uuid, 16);
>  			free(mp->path);
>  			mp->path = path ? strdup(path) : NULL;
> +			mp->bad = 0;
>  			break;
>  		}
>  	if (!mp)

applied, thanks.

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]