Re: md:Add judgement bb->unacked_exist in function

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]

On Thu, 8 Mar 2012 17:37:45 +0800 "kedacomkernel" <kedacomkernel@gmail.com>
wrote:

> >From 7054a9dcd23a721e3c3dd2ceb8f1243187ea5cc4 Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@gmail.com>
> Date: Thu, 8 Mar 2012 17:31:32 +0800
> Subject: [PATCH] md:Add judgement bb->unacked_exist in function
>  md_ack_all_badblocks().
> 
> 
> Signed-off-by: majianpeng <majianpeng@gmail.com>
> ---
>  drivers/md/md.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index ce88755..7c57d0f 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -8040,7 +8040,7 @@ void md_ack_all_badblocks(struct badblocks *bb)
>  		return;
>  	write_seqlock_irq(&bb->lock);
>  
> -	if (bb->changed == 0) {
> +	if (bb->changed == 0 && bb->unacked_exist) {
>  		u64 *p = bb->page;
>  		int i;
>  		for (i = 0; i < bb->count ; i++) {

Thanks.
This is fairly minor optimisation as 'unacked_exists' it almost always true
when ->change is set, but I doesn't hurt so I've included it.

In general I prefer a slightly more details commit comment.  It doesn't have
to be long, but it should make it obvious why the change is needed and what
it does.
I have made it:

    md: Add judgement bb->unacked_exist in function md_ack_all_badblocks().
    
    If there are no unacked bad blocks, then there is no point searching
    for them to acknowledge them.
    
    
    Signed-off-by: majianpeng <majianpeng@gmail.com>
    Signed-off-by: NeilBrown <neilb@suse.de>

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]