* md:Add break if find.
@ 2012-03-13 5:28 majianpeng
2012-03-14 2:06 ` NeilBrown
2012-03-14 2:30 ` kedacomkernel
0 siblings, 2 replies; 3+ messages in thread
From: majianpeng @ 2012-03-13 5:28 UTC (permalink / raw)
To: Neil Brown; +Cc: linux-raid
From 6e04c2374db7fc34ccbf9f37f85e735a349c816c Mon Sep 17 00:00:00 2001
From: majianpeng <majianpeng@gmail.com>
Date: Tue, 13 Mar 2012 13:26:25 +0800
Subject: [PATCH] md:Add break if find.
Signed-off-by: majianpeng <majianpeng@gmail.com>
---
drivers/md/raid5.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 360f2b9..e05d9e5 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -4369,8 +4369,10 @@ static inline sector_t sync_request(struct mddev *mddev, sector_t sector_nr, int
* recovery aborts.
*/
for (i = 0; i < conf->raid_disks; i++)
- if (conf->disks[i].rdev == NULL)
+ if (conf->disks[i].rdev == NULL) {
still_degraded = 1;
+ break;
+ }
bitmap_start_sync(mddev->bitmap, sector_nr, &sync_blocks, still_degraded);
--
1.7.5.4
--------------
majianpeng
2012-03-13
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: md:Add break if find.
2012-03-13 5:28 md:Add break if find majianpeng
@ 2012-03-14 2:06 ` NeilBrown
2012-03-14 2:30 ` kedacomkernel
1 sibling, 0 replies; 3+ messages in thread
From: NeilBrown @ 2012-03-14 2:06 UTC (permalink / raw)
To: majianpeng; +Cc: linux-raid
[-- Attachment #1: Type: text/plain, Size: 1282 bytes --]
On Tue, 13 Mar 2012 13:28:12 +0800 "majianpeng" <majianpeng@gmail.com> wrote:
> >From 6e04c2374db7fc34ccbf9f37f85e735a349c816c Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@gmail.com>
> Date: Tue, 13 Mar 2012 13:26:25 +0800
> Subject: [PATCH] md:Add break if find.
>
>
> Signed-off-by: majianpeng <majianpeng@gmail.com>
> ---
> drivers/md/raid5.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 360f2b9..e05d9e5 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -4369,8 +4369,10 @@ static inline sector_t sync_request(struct mddev *mddev, sector_t sector_nr, int
> * recovery aborts.
> */
> for (i = 0; i < conf->raid_disks; i++)
> - if (conf->disks[i].rdev == NULL)
> + if (conf->disks[i].rdev == NULL) {
> still_degraded = 1;
> + break;
> + }
>
> bitmap_start_sync(mddev->bitmap, sector_nr, &sync_blocks, still_degraded);
>
Thanks - however I don't think I'll apply this one.
It is a micro optimisation which only improve an uncommon case a little,
but it makes the source code long and the generated machine code longer (by
32 bytes on x86_64).
So I don't really think it is a win.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Re: md:Add break if find.
2012-03-13 5:28 md:Add break if find majianpeng
2012-03-14 2:06 ` NeilBrown
@ 2012-03-14 2:30 ` kedacomkernel
1 sibling, 0 replies; 3+ messages in thread
From: kedacomkernel @ 2012-03-14 2:30 UTC (permalink / raw)
To: NeilBrown; +Cc: linux-raid
Thansk,I know.
------------------
kedacomkernel
2012-03-14
-------------------------------------------------------------
发件人：NeilBrown
发送日期：2012-03-14 10:06:35
收件人：majianpeng
抄送：linux-raid
主题：Re: md:Add break if find.
On Tue, 13 Mar 2012 13:28:12 +0800 "majianpeng" <majianpeng@gmail.com> wrote:
> >From 6e04c2374db7fc34ccbf9f37f85e735a349c816c Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@gmail.com>
> Date: Tue, 13 Mar 2012 13:26:25 +0800
> Subject: [PATCH] md:Add break if find.
>
>
> Signed-off-by: majianpeng <majianpeng@gmail.com>
> ---
> drivers/md/raid5.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 360f2b9..e05d9e5 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -4369,8 +4369,10 @@ static inline sector_t sync_request(struct mddev *mddev, sector_t sector_nr, int
> * recovery aborts.
> */
> for (i = 0; i < conf->raid_disks; i++)
> - if (conf->disks[i].rdev == NULL)
> + if (conf->disks[i].rdev == NULL) {
> still_degraded = 1;
> + break;
> + }
>
> bitmap_start_sync(mddev->bitmap, sector_nr, &sync_blocks, still_degraded);
>
Thanks - however I don't think I'll apply this one.
It is a micro optimisation which only improve an uncommon case a little,
but it makes the source code long and the generated machine code longer (by
32 bytes on x86_64).
So I don't really think it is a win.
Thanks,
NeilBrown
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-14 2:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-13 5:28 md:Add break if find majianpeng
2012-03-14 2:06 ` NeilBrown
2012-03-14 2:30 ` kedacomkernel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).