From: "majianpeng" <majianpeng@gmail.com>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Question about handle_failed_sync()
Date: Wed, 14 Mar 2012 15:16:45 +0800 [thread overview]
Message-ID: <201203141516404211761@gmail.com> (raw)
In function handle_failed_sync():
>>/* During recovery devices cannot be removed, so locking and
>> * refcounting of rdevs is not needed
>> */
>> for (i = 0; i < conf->raid_disks; i++) {
>> struct md_rdev *rdev = conf->disks[i].rdev;
>> if (rdev
>> && !test_bit(Faulty, &rdev->flags)
>> && !test_bit(In_sync, &rdev->flags)
>> && !rdev_set_badblocks(rdev, sh->sector,
>> STRIPE_SECTORS, 0))
>> abort = 1;
I have two questions:
1:if raid have two or more spare disks, it wil set bad block on all spare disk. Is it worth it?
2:If raid have two or more spare disks,I can remove spare disks which not working for recovery.Then you shold add locking
and refconting.
--------------
majianpeng
2012-03-14
next reply other threads:[~2012-03-14 7:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 7:16 majianpeng [this message]
2012-03-14 7:28 ` Question about handle_failed_sync() NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203141516404211761@gmail.com \
--to=majianpeng@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).