linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: majianpeng <majianpeng@gmail.com>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: md/raid5:Fix recover/replace stop if handle stipe failed
Date: Wed, 28 Mar 2012 13:14:49 +1100	[thread overview]
Message-ID: <20120328131449.2ad9896f@notabene.brown> (raw)
In-Reply-To: <201203280945342813684@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 728 bytes --]

On Wed, 28 Mar 2012 09:45:40 +0800 "majianpeng" <majianpeng@gmail.com> wrote:

> >>However I don't agree that we need to set 'abort = 1' in the non-RECOVERY
> >>case.
> But the origial code is:
> md_done_sync(conf->mddev, STRIPE_SECTORS, 0)
> This mean you will interrunt the resync.

Correct.  But I now think the original code was wrong - or at least
unnecessary and addition of known-bad-blocks has made it wrong.

Thanks,
NeilBrown


> 
> ------------------				 
> majianpeng
> 2012-03-28
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  reply	other threads:[~2012-03-28  2:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-14  7:07 md/raid5:Fix recover/replace stop if handle stipe failed majianpeng
2012-03-14  7:33 ` NeilBrown
2012-03-14  9:27 ` majianpeng
2012-03-27  3:26   ` NeilBrown
2012-03-27  7:33     ` majianpeng
2012-03-28  1:40       ` NeilBrown
2012-03-28  1:45       ` majianpeng
2012-03-28  2:14         ` NeilBrown [this message]
2012-03-28  2:25           ` majianpeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120328131449.2ad9896f@notabene.brown \
    --to=neilb@suse.de \
    --cc=linux-raid@vger.kernel.org \
    --cc=majianpeng@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).