md:Add the judgement about the size of suspend_lo and suspend_hi.

md:Add the judgement about the size of suspend_lo and suspend_hi.

[majianpeng]

From 7b8db5f9559feef49859056407a7cee656bcfc45 Mon Sep 17 00:00:00 2001
From: majianpeng <majianpeng@gmail.com>
Date: Wed, 28 Mar 2012 19:43:58 +0800
Subject: [PATCH] md:Add the judgement about the size of suspend_lo and
 suspend_hi.


Signed-off-by: majianpeng <majianpeng@gmail.com>
---
 drivers/md/md.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index b572e1e..7180ac3 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -4364,6 +4364,8 @@ suspend_lo_store(struct mddev *mddev, const char *buf, size_t len)
 		return -EINVAL;
 	if (buf == e || (*e && *e != '\n'))
 		return -EINVAL;
+	if (new > mddev->suspend_hi)
+		return -EINVAL;
 
 	mddev->suspend_lo = new;
 	if (new >= old)
@@ -4398,6 +4400,8 @@ suspend_hi_store(struct mddev *mddev, const char *buf, size_t len)
 		return -EINVAL;
 	if (buf == e || (*e && *e != '\n'))
 		return -EINVAL;
+	if (new < mddev->suspend_lo)
+		return -EINVAL;
 
 	mddev->suspend_hi = new;
 	if (new <= old)
-- 
1.7.5.4

 				
--------------
majianpeng
2012-03-28

Re: md:Add the judgement about the size of suspend_lo and suspend_hi.

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

On Wed, 28 Mar 2012 19:49:38 +0800 "majianpeng" <majianpeng@gmail.com> wrote:

> >From 7b8db5f9559feef49859056407a7cee656bcfc45 Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@gmail.com>
> Date: Wed, 28 Mar 2012 19:43:58 +0800
> Subject: [PATCH] md:Add the judgement about the size of suspend_lo and
>  suspend_hi.
> 
> 


you patches could use a little more text explaining them too.

In this case I think it is wrong.  There is no reason at all why lo should
always be less than or equal to hi.  Imposing that is an unnecessary burden.

Not applied.

Thanks,
NeilBrown

> Signed-off-by: majianpeng <majianpeng@gmail.com>
> ---
>  drivers/md/md.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index b572e1e..7180ac3 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -4364,6 +4364,8 @@ suspend_lo_store(struct mddev *mddev, const char *buf, size_t len)
>  		return -EINVAL;
>  	if (buf == e || (*e && *e != '\n'))
>  		return -EINVAL;
> +	if (new > mddev->suspend_hi)
> +		return -EINVAL;
>  
>  	mddev->suspend_lo = new;
>  	if (new >= old)
> @@ -4398,6 +4400,8 @@ suspend_hi_store(struct mddev *mddev, const char *buf, size_t len)
>  		return -EINVAL;
>  	if (buf == e || (*e && *e != '\n'))
>  		return -EINVAL;
> +	if (new < mddev->suspend_lo)
> +		return -EINVAL;
>  
>  	mddev->suspend_hi = new;
>  	if (new <= old)


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]