From: "majianpeng" <majianpeng@gmail.com>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: md/raid1:Remove unnecessary judgement.
Date: Sat, 31 Mar 2012 10:05:23 +0800 [thread overview]
Message-ID: <201203311005202344147@gmail.com> (raw)
From 033a0330eb210750ec09202ed95696b54d9afeba Mon Sep 17 00:00:00 2001
From: majianpeng <majianpeng@gmail.com>
Date: Sat, 31 Mar 2012 09:57:42 +0800
Subject: [PATCH] md/raid1:Remove unnecessary judgement.
If success == 1 then break the do{}while,so did not judge !success.
Signed-off-by: majianpeng <majianpeng@gmail.com>
---
drivers/md/raid1.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 4a40a20..649941b 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -1624,7 +1624,7 @@ static int fix_sync_read_error(struct r1bio *r1_bio)
d++;
if (d == conf->raid_disks * 2)
d = 0;
- } while (!success && d != r1_bio->read_disk);
+ } while (d != r1_bio->read_disk);
if (!success) {
char b[BDEVNAME_SIZE];
--
1.7.5.4
--------------
majianpeng
2012-03-31
next reply other threads:[~2012-03-31 2:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-31 2:05 majianpeng [this message]
2012-04-02 1:25 ` md/raid1:Remove unnecessary judgement NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203311005202344147@gmail.com \
--to=majianpeng@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).