linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "kedacomkernel" <kedacomkernel@gmail.com>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: md/raid1:Fix a logic bug in fix_sync_read_error().
Date: Sat, 31 Mar 2012 10:38:01 +0800	[thread overview]
Message-ID: <201203311037586565381@gmail.com> (raw)

From 0fe15c8e1bd5e46234d37573f3322312d8da325d Mon Sep 17 00:00:00 2001
From: majianpeng <majianpeng@gmail.com>
Date: Sat, 31 Mar 2012 10:27:33 +0800
Subject: [PATCH] md/raid1:Fix a logic bug in fix_sync_read_error(). 
If  d==read_disk && success == 1 and then break, so d =
 read_disk. When exec this judgement: >>start = d; >>/*
 write it back and re-read */ >>while (d !=
 r1_bio->read_disk) { Because d == read_disk,so write and
 re-add did not exec.


Signed-off-by: majianpeng <majianpeng@gmail.com>
---
 drivers/md/raid1.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 4a40a20..3a133ff 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -1618,7 +1618,6 @@ static int fix_sync_read_error(struct r1bio *r1_bio)
 						 bio->bi_io_vec[idx].bv_page,
 						 READ, false)) {
 					success = 1;
-					break;
 				}
 			}
 			d++;
-- 
1.7.5.4

kedacomkernel
2012-03-31


             reply	other threads:[~2012-03-31  2:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-31  2:38 kedacomkernel [this message]
2012-04-02  2:05 ` md/raid1:Fix a logic bug in fix_sync_read_error() NeilBrown
2012-04-05  2:23 ` kedacomkernel
2012-04-05  3:36   ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203311037586565381@gmail.com \
    --to=kedacomkernel@gmail.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).