linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: majianpeng <majianpeng@gmail.com>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: md:Add the judgement about the size of suspend_lo and suspend_hi.
Date: Mon, 2 Apr 2012 11:05:44 +1000	[thread overview]
Message-ID: <20120402110544.0797cde1@notabene.brown> (raw)
In-Reply-To: <201203281949331251132@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

On Wed, 28 Mar 2012 19:49:38 +0800 "majianpeng" <majianpeng@gmail.com> wrote:

> >From 7b8db5f9559feef49859056407a7cee656bcfc45 Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@gmail.com>
> Date: Wed, 28 Mar 2012 19:43:58 +0800
> Subject: [PATCH] md:Add the judgement about the size of suspend_lo and
>  suspend_hi.
> 
> 


you patches could use a little more text explaining them too.

In this case I think it is wrong.  There is no reason at all why lo should
always be less than or equal to hi.  Imposing that is an unnecessary burden.

Not applied.

Thanks,
NeilBrown

> Signed-off-by: majianpeng <majianpeng@gmail.com>
> ---
>  drivers/md/md.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index b572e1e..7180ac3 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -4364,6 +4364,8 @@ suspend_lo_store(struct mddev *mddev, const char *buf, size_t len)
>  		return -EINVAL;
>  	if (buf == e || (*e && *e != '\n'))
>  		return -EINVAL;
> +	if (new > mddev->suspend_hi)
> +		return -EINVAL;
>  
>  	mddev->suspend_lo = new;
>  	if (new >= old)
> @@ -4398,6 +4400,8 @@ suspend_hi_store(struct mddev *mddev, const char *buf, size_t len)
>  		return -EINVAL;
>  	if (buf == e || (*e && *e != '\n'))
>  		return -EINVAL;
> +	if (new < mddev->suspend_lo)
> +		return -EINVAL;
>  
>  	mddev->suspend_hi = new;
>  	if (new <= old)


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

      reply	other threads:[~2012-04-02  1:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-28 11:49 md:Add the judgement about the size of suspend_lo and suspend_hi majianpeng
2012-04-02  1:05 ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120402110544.0797cde1@notabene.brown \
    --to=neilb@suse.de \
    --cc=linux-raid@vger.kernel.org \
    --cc=majianpeng@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).