* [PATCH] md/raid1:Using 1 instead of update.
@ 2012-04-01 2:36 majianpeng
2012-04-02 2:01 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: majianpeng @ 2012-04-01 2:36 UTC (permalink / raw)
To: Neil Brown; +Cc: linux-raid
From 6991dc532e4d655fb509ba1dbe7a9869b0cd33d9 Mon Sep 17 00:00:00 2001
From: majianpeng <majianpeng@gmail.com>
Date: Sun, 1 Apr 2012 10:31:52 +0800
Subject: [PATCH] md/raid1:Using 1 instead of update.
If update == 0 and then set R1BIO_WriteError,so did not exec md_do_sync().
Signed-off-by: majianpeng <majianpeng@gmail.com>
---
drivers/md/raid1.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 4a40a20..def1ed1 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -1554,7 +1554,7 @@ static void end_sync_write(struct bio *bio, int error)
reschedule_retry(r1_bio);
else {
put_buf(r1_bio);
- md_done_sync(mddev, s, uptodate);
+ md_done_sync(mddev, s, 1);
}
}
}
--
1.7.5.4
--------------
majianpeng
2012-04-01
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] md/raid1:Using 1 instead of update.
2012-04-01 2:36 [PATCH] md/raid1:Using 1 instead of update majianpeng
@ 2012-04-02 2:01 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2012-04-02 2:01 UTC (permalink / raw)
To: majianpeng; +Cc: linux-raid
[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]
On Sun, 1 Apr 2012 10:36:32 +0800 "majianpeng" <majianpeng@gmail.com> wrote:
> >From 6991dc532e4d655fb509ba1dbe7a9869b0cd33d9 Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@gmail.com>
> Date: Sun, 1 Apr 2012 10:31:52 +0800
> Subject: [PATCH] md/raid1:Using 1 instead of update.
> If update == 0 and then set R1BIO_WriteError,so did not exec md_do_sync().
>
>
> Signed-off-by: majianpeng <majianpeng@gmail.com>
> ---
> drivers/md/raid1.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index 4a40a20..def1ed1 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -1554,7 +1554,7 @@ static void end_sync_write(struct bio *bio, int error)
> reschedule_retry(r1_bio);
> else {
> put_buf(r1_bio);
> - md_done_sync(mddev, s, uptodate);
> + md_done_sync(mddev, s, 1);
> }
> }
> }
Again, I think this hurts readability - it is less obvious that it is correct.
So I'll leave it as it is.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-02 2:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-01 2:36 [PATCH] md/raid1:Using 1 instead of update majianpeng
2012-04-02 2:01 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).