From: NeilBrown <neilb@suse.de>
To: "Labun, Marcin" <Marcin.Labun@intel.com>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>
Subject: Re: [PATCH] imsm: display maximum volumes per controller and array
Date: Tue, 17 Apr 2012 12:31:41 +1000 [thread overview]
Message-ID: <20120417123141.5330ce20@notabene.brown> (raw)
In-Reply-To: <F9123E44003394499FDD2B17C60621D41861C0FB@IRSMSX101.ger.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 2250 bytes --]
On Wed, 11 Apr 2012 14:25:41 +0000 "Labun, Marcin" <Marcin.Labun@intel.com>
wrote:
> Display maximum volumes per array and per controller
> in --detail-platform command.
>
> Signed-off-by: Marcin Labun <marcin.labun@intel.com>
> ---
> super-intel.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index dad4c4d..1e6df30 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -1783,12 +1783,13 @@ static void print_imsm_capability(const struct imsm_orom *orom)
> imsm_orom_has_chunk(orom, 1024*16) ? " 16M" : "",
> imsm_orom_has_chunk(orom, 1024*32) ? " 32M" : "",
> imsm_orom_has_chunk(orom, 1024*64) ? " 64M" : "");
> - printf(" Max Disks : %d\n", orom->tds);
> - printf(" Max Volumes : %d\n", orom->vpa);
> printf(" 2TB volumes :%s supported\n",
> (orom->attr & IMSM_OROM_ATTR_2TB)?"":" not");
> printf(" 2TB disks :%s supported\n",
> (orom->attr & IMSM_OROM_ATTR_2TB_DISK)?"":" not");
> + printf(" Max Disks : %d\n", orom->tds);
> + printf(" Max Volumes per array : %d\n", orom->vpa);
> + printf(" Max Volumes per controller: %d\n", orom->vphba);
> return;
> }
>
Thanks. However this messes up the formatting.
I've changed it to the following, and applied.
Thanks,
NeilBrown
diff --git a/super-intel.c b/super-intel.c
index ed7792d..088e6bc 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -1783,12 +1783,13 @@ static void print_imsm_capability(const struct imsm_orom *orom)
imsm_orom_has_chunk(orom, 1024*16) ? " 16M" : "",
imsm_orom_has_chunk(orom, 1024*32) ? " 32M" : "",
imsm_orom_has_chunk(orom, 1024*64) ? " 64M" : "");
- printf(" Max Disks : %d\n", orom->tds);
- printf(" Max Volumes : %d\n", orom->vpa);
printf(" 2TB volumes :%s supported\n",
(orom->attr & IMSM_OROM_ATTR_2TB)?"":" not");
printf(" 2TB disks :%s supported\n",
(orom->attr & IMSM_OROM_ATTR_2TB_DISK)?"":" not");
+ printf(" Max Disks : %d\n", orom->tds);
+ printf(" Max Volumes : %d per array, %d per controller\n",
+ orom->vpa, orom->vphba);
return;
}
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2012-04-17 2:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 14:25 [PATCH] imsm: display maximum volumes per controller and array Labun, Marcin
2012-04-17 2:31 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417123141.5330ce20@notabene.brown \
--to=neilb@suse.de \
--cc=Marcin.Labun@intel.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).