From: NeilBrown <neilb@suse.de>
To: Brassow Jonathan <jbrassow@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
linux-raid@vger.kernel.org, agk@redhat.com
Subject: Re: [dm-devel] [PATCH 0 of 4] dm-raid: various bug fixes
Date: Thu, 19 Apr 2012 09:58:08 +1000 [thread overview]
Message-ID: <20120419095808.323b01b0@notabene.brown> (raw)
In-Reply-To: <A71FAACD-D1A7-4452-BDD3-5156DB9E5497@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]
On Wed, 18 Apr 2012 16:32:00 -0500 Brassow Jonathan <jbrassow@redhat.com>
wrote:
>
> On Apr 18, 2012, at 9:05 AM, Brassow Jonathan wrote:
>
> >
> > 5-of-5: changing the check to 'saved_raid_disk >= 0' would be fine, but I think I should initialize 'saved_raid_disk' to -1 in dm-raid.c then normally. Right now, an nominal initial value is not set - meaning it is '0'. (When a device comes back from a failure, 'saved_raid_disk' is assigned its old position.)
>
> ... that's not quite right. I do call 'md_rdev_init' which sets 'saved_raid_disk' to -1. Then, if the device has returned after a disappearance, I set 'saved_raid_disk' to it's old position. Therefore, 'saved_raid_disk >= 0' would be fine and wouldn't require me to set -1 in dm-raid.c.
>
> brassow
>
Excellent. I've taken the liberty of making that change in the patch you
sent me and converted your RFC-by: to Signed-off-by:
Result can be viewed at or near the top of
http://neil.brown.name/git?p=md;a=shortlog;h=refs/heads/for-next
Please confirm that is OK to submit (eventually for 3.5).
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2012-04-18 23:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 2:30 [PATCH 0 of 4] dm-raid: various bug fixes Jonathan Brassow
2012-04-18 2:36 ` [PATCH 1 of 5] DM RAID: Set recovery flags on resume Jonathan Brassow
2012-04-18 2:37 ` [PATCH 2 of 5] DM RAID: Record and handle missing devices Jonathan Brassow
2012-04-18 2:38 ` [PATCH 3 of 5] DM RAID: Use safe version of rdev_for_each Jonathan Brassow
2012-04-18 2:41 ` [PATCH 4 of 5] DM RAID: Use md_error() in place of simply setting Faulty bit Jonathan Brassow
2012-04-18 2:43 ` [PATCH 5 of 5] MD RAID1: Further conditionalize 'fullsync' Jonathan Brassow
2012-04-18 3:48 ` [PATCH 0 of 4] dm-raid: various bug fixes NeilBrown
2012-04-18 14:05 ` Brassow Jonathan
2012-04-18 21:32 ` Brassow Jonathan
2012-04-18 23:58 ` NeilBrown [this message]
2012-04-19 2:42 ` [dm-devel] " Brassow Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120419095808.323b01b0@notabene.brown \
--to=neilb@suse.de \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=jbrassow@redhat.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).