From: NeilBrown <neilb@suse.de>
To: Lukasz Dorau <lukasz.dorau@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com
Subject: Re: [PATCH] fix: correct extending size of raid0 array
Date: Mon, 23 Apr 2012 10:12:52 +1000 [thread overview]
Message-ID: <20120423101252.3f337002@notabene.brown> (raw)
In-Reply-To: <20120420090025.32107.93930.stgit@gklab-128-085.igk.intel.com>
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
On Fri, 20 Apr 2012 11:00:25 +0200 Lukasz Dorau <lukasz.dorau@intel.com>
wrote:
> Setting "sync_action" to "idle" while extending size of raid0 array
> is racy and sometimes fails.
> "sync_action" should be set to "frozen" instead.
>
> Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
> ---
> Grow.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Grow.c b/Grow.c
> index 389992e..b4b9ff2 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -1749,7 +1749,7 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
> /* do not recync non-existing parity,
> * we will drop it anyway
> */
> - sysfs_set_str(sra, NULL, "sync_action", "idle");
> + sysfs_set_str(sra, NULL, "sync_action", "frozen");
> /* go back to raid0, drop parity disk
> */
> sysfs_set_str(sra, NULL, "level", "raid0");
applied,
thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2012-04-23 0:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 9:00 [PATCH] fix: correct extending size of raid0 array Lukasz Dorau
2012-04-23 0:12 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423101252.3f337002@notabene.brown \
--to=neilb@suse.de \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=lukasz.dorau@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).