* [PATCH] fix: correct extending size of raid0 array
@ 2012-04-20 9:00 Lukasz Dorau
2012-04-23 0:12 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: Lukasz Dorau @ 2012-04-20 9:00 UTC (permalink / raw)
To: neilb; +Cc: linux-raid, dan.j.williams, ed.ciechanowski
Setting "sync_action" to "idle" while extending size of raid0 array
is racy and sometimes fails.
"sync_action" should be set to "frozen" instead.
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
---
Grow.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Grow.c b/Grow.c
index 389992e..b4b9ff2 100644
--- a/Grow.c
+++ b/Grow.c
@@ -1749,7 +1749,7 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
/* do not recync non-existing parity,
* we will drop it anyway
*/
- sysfs_set_str(sra, NULL, "sync_action", "idle");
+ sysfs_set_str(sra, NULL, "sync_action", "frozen");
/* go back to raid0, drop parity disk
*/
sysfs_set_str(sra, NULL, "level", "raid0");
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fix: correct extending size of raid0 array
2012-04-20 9:00 [PATCH] fix: correct extending size of raid0 array Lukasz Dorau
@ 2012-04-23 0:12 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2012-04-23 0:12 UTC (permalink / raw)
To: Lukasz Dorau; +Cc: linux-raid, dan.j.williams, ed.ciechanowski
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
On Fri, 20 Apr 2012 11:00:25 +0200 Lukasz Dorau <lukasz.dorau@intel.com>
wrote:
> Setting "sync_action" to "idle" while extending size of raid0 array
> is racy and sometimes fails.
> "sync_action" should be set to "frozen" instead.
>
> Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
> ---
> Grow.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Grow.c b/Grow.c
> index 389992e..b4b9ff2 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -1749,7 +1749,7 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
> /* do not recync non-existing parity,
> * we will drop it anyway
> */
> - sysfs_set_str(sra, NULL, "sync_action", "idle");
> + sysfs_set_str(sra, NULL, "sync_action", "frozen");
> /* go back to raid0, drop parity disk
> */
> sysfs_set_str(sra, NULL, "level", "raid0");
applied,
thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-23 0:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-20 9:00 [PATCH] fix: correct extending size of raid0 array Lukasz Dorau
2012-04-23 0:12 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).