[PATCH] imsm: fix: thunderdome may drop 2tb attribute

[PATCH] imsm: fix: thunderdome may drop 2tb attribute

[Czarnowska, Anna]

Spare superblock doesn't depend on other spares in container.
When loading container metadata thunderdome
may pick a small disk for the champion. This will result in incorrect
interpretation of sizes of other disks in container when joint superblock
is returned. If any disk in container has the 2TB attribute set, the result
must have it set too.

Signed-off-by: Anna Czarnowska <anna.czarnowska@intel.com>
---
 super-intel.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/super-intel.c b/super-intel.c
index ed13542..869a39c 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -4079,6 +4079,8 @@ imsm_thunderdome(struct intel_super **super_list, int len)
 		if (s == champion)
 			continue;
 
+		mpb->attributes |= s->anchor->attributes & MPB_ATTRIB_2TB_DISK;
+
 		for (i = 0; i < mpb->num_disks; i++) {
 			struct imsm_disk *disk;
 
-- 
1.6.4.2

RE: [PATCH] imsm: fix: thunderdome may drop 2tb attribute

[Czarnowska, Anna]

Hi Neil,
this patch is quite important. It seems to have been overlooked
Regards
Anna

> -----Original Message-----
> From: linux-raid-owner@vger.kernel.org [mailto:linux-raid-
> owner@vger.kernel.org] On Behalf Of Czarnowska, Anna
> Sent: Monday, April 02, 2012 10:59 PM
> To: NeilBrown
> Cc: linux-raid@vger.kernel.org; Williams, Dan J; Ciechanowski, Ed;
> Grabowski, Grzegorz
> Subject: [PATCH] imsm: fix: thunderdome may drop 2tb attribute
> 
> Spare superblock doesn't depend on other spares in container.
> When loading container metadata thunderdome
> may pick a small disk for the champion. This will result in incorrect
> interpretation of sizes of other disks in container when joint
> superblock
> is returned. If any disk in container has the 2TB attribute set, the
> result
> must have it set too.
> 
> Signed-off-by: Anna Czarnowska <anna.czarnowska@intel.com>
> ---
>  super-intel.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/super-intel.c b/super-intel.c
> index ed13542..869a39c 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -4079,6 +4079,8 @@ imsm_thunderdome(struct intel_super **super_list,
> int len)
>  		if (s == champion)
>  			continue;
> 
> +		mpb->attributes |= s->anchor->attributes &
> MPB_ATTRIB_2TB_DISK;
> +
>  		for (i = 0; i < mpb->num_disks; i++) {
>  			struct imsm_disk *disk;
> 
> --
> 1.6.4.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] imsm: fix: thunderdome may drop 2tb attribute

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 2134 bytes --]

On Fri, 27 Apr 2012 08:58:14 +0000 "Czarnowska, Anna"
<anna.czarnowska@intel.com> wrote:

> Hi Neil,
> this patch is quite important. It seems to have been overlooked

Yes I had over-looked it.  Thanks for the reminder.  It is applied now.

NeilBrown



> Regards
> Anna
> 
> > -----Original Message-----
> > From: linux-raid-owner@vger.kernel.org [mailto:linux-raid-
> > owner@vger.kernel.org] On Behalf Of Czarnowska, Anna
> > Sent: Monday, April 02, 2012 10:59 PM
> > To: NeilBrown
> > Cc: linux-raid@vger.kernel.org; Williams, Dan J; Ciechanowski, Ed;
> > Grabowski, Grzegorz
> > Subject: [PATCH] imsm: fix: thunderdome may drop 2tb attribute
> > 
> > Spare superblock doesn't depend on other spares in container.
> > When loading container metadata thunderdome
> > may pick a small disk for the champion. This will result in incorrect
> > interpretation of sizes of other disks in container when joint
> > superblock
> > is returned. If any disk in container has the 2TB attribute set, the
> > result
> > must have it set too.
> > 
> > Signed-off-by: Anna Czarnowska <anna.czarnowska@intel.com>
> > ---
> >  super-intel.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/super-intel.c b/super-intel.c
> > index ed13542..869a39c 100644
> > --- a/super-intel.c
> > +++ b/super-intel.c
> > @@ -4079,6 +4079,8 @@ imsm_thunderdome(struct intel_super **super_list,
> > int len)
> >  		if (s == champion)
> >  			continue;
> > 
> > +		mpb->attributes |= s->anchor->attributes &
> > MPB_ATTRIB_2TB_DISK;
> > +
> >  		for (i = 0; i < mpb->num_disks; i++) {
> >  			struct imsm_disk *disk;
> > 
> > --
> > 1.6.4.2
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-raid"
> > in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]