From: NeilBrown <neilb@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Jes.Sorensen@redhat.com, linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/2] super-intel.c: Don't try to close negative fd
Date: Mon, 7 May 2012 09:10:33 +1000 [thread overview]
Message-ID: <20120507091033.3d797914@notabene.brown> (raw)
In-Reply-To: <CAA9_cmcnWHeu-x9L5os9gZzmhtMxvAWVnLf3uSfey+aVktaKoA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
On Fri, 4 May 2012 11:00:15 -0700 Dan Williams <dan.j.williams@intel.com>
wrote:
> On Fri, May 4, 2012 at 6:41 AM, <Jes.Sorensen@redhat.com> wrote:
> > From: Jes Sorensen <Jes.Sorensen@redhat.com>
> >
> > This should be harmless, but lets be consistent and not try to close a
> > negative file descripter.
> >
> > Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
> > ---
>
> Patch 1 and 2, Acked-by: Dan Williams <dan.j.williams@intel.com>
Thanks to you both.
Patches applied.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2012-05-06 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 13:41 [PATCH 1/2] super-intel.c: Don't try to close negative fd Jes.Sorensen
2012-05-04 13:41 ` [PATCH 2/2] super-intel.c: Fix resource leak from opendir() Jes.Sorensen
2012-05-04 18:00 ` [PATCH 1/2] super-intel.c: Don't try to close negative fd Dan Williams
2012-05-06 23:10 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120507091033.3d797914@notabene.brown \
--to=neilb@suse.de \
--cc=Jes.Sorensen@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).