From: NeilBrown <neilb@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-raid@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] md/raid10: unlock on error path in raid10_start_reshape()
Date: Thu, 17 May 2012 17:39:24 +1000 [thread overview]
Message-ID: <20120517173924.186266d1@notabene.brown> (raw)
In-Reply-To: <20120517064911.GB14660@elgon.mountain>
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
On Thu, 17 May 2012 09:49:11 +0300 Dan Carpenter <dan.carpenter@oracle.com>
wrote:
> We need to unlock and enable IRQs before returning here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index e8ed1d8..ba7290f 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -3918,6 +3918,7 @@ static int raid10_start_reshape(struct mddev *mddev)
> if (mddev->reshape_backwards) {
> sector_t size = raid10_size(mddev, 0, 0);
> if (size < mddev->array_sectors) {
> + spin_unlock_irq(&conf->device_lock);
> printk(KERN_ERR "md/raid10:%s: array size must be reduce before number of disks\n",
> mdname(mddev));
> return -EINVAL;
Hi Dan,
thanks heaps for this!!
I've merged the change into the original patch with suitable attribution.
The result should get into tomorrows linux-next.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2012-05-17 7:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 6:49 [patch] md/raid10: unlock on error path in raid10_start_reshape() Dan Carpenter
2012-05-17 7:39 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120517173924.186266d1@notabene.brown \
--to=neilb@suse.de \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).