* [patch] md/raid10: unlock on error path in raid10_start_reshape()
@ 2012-05-17 6:49 Dan Carpenter
2012-05-17 7:39 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-05-17 6:49 UTC (permalink / raw)
To: Neil Brown; +Cc: linux-raid, kernel-janitors
We need to unlock and enable IRQs before returning here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index e8ed1d8..ba7290f 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -3918,6 +3918,7 @@ static int raid10_start_reshape(struct mddev *mddev)
if (mddev->reshape_backwards) {
sector_t size = raid10_size(mddev, 0, 0);
if (size < mddev->array_sectors) {
+ spin_unlock_irq(&conf->device_lock);
printk(KERN_ERR "md/raid10:%s: array size must be reduce before number of disks\n",
mdname(mddev));
return -EINVAL;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] md/raid10: unlock on error path in raid10_start_reshape()
2012-05-17 6:49 [patch] md/raid10: unlock on error path in raid10_start_reshape() Dan Carpenter
@ 2012-05-17 7:39 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2012-05-17 7:39 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-raid, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
On Thu, 17 May 2012 09:49:11 +0300 Dan Carpenter <dan.carpenter@oracle.com>
wrote:
> We need to unlock and enable IRQs before returning here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index e8ed1d8..ba7290f 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -3918,6 +3918,7 @@ static int raid10_start_reshape(struct mddev *mddev)
> if (mddev->reshape_backwards) {
> sector_t size = raid10_size(mddev, 0, 0);
> if (size < mddev->array_sectors) {
> + spin_unlock_irq(&conf->device_lock);
> printk(KERN_ERR "md/raid10:%s: array size must be reduce before number of disks\n",
> mdname(mddev));
> return -EINVAL;
Hi Dan,
thanks heaps for this!!
I've merged the change into the original patch with suitable attribution.
The result should get into tomorrows linux-next.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-17 7:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-17 6:49 [patch] md/raid10: unlock on error path in raid10_start_reshape() Dan Carpenter
2012-05-17 7:39 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).