* About raid5 read error handle when raid5 was degraded.
@ 2012-05-21 10:47 majianpeng
2012-05-21 22:36 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: majianpeng @ 2012-05-21 10:47 UTC (permalink / raw)
To: Neil Brown; +Cc: linux-raid
Hi all:
I readed the latest code in function :
raid5_end_read_request():
>> else if (conf->mddev->degraded >= conf->max_degraded)
>> printk_ratelimited(
>> KERN_WARNING
>> "md/raid:%s: read error not correctable "
>> "(sector %llu on %s).\n",
>> mdname(conf->mddev),
>> (unsigned long long)(sh->sector
>> + rdev->data_offset),
>> bdn);
If this occur,then exec md_error().In md_error(), remove this disk.
The raid5 will fail and lost all data.
Why do call rdev_set_badsector() for this situation?
Thanks!
--------------
majianpeng
2012-05-21
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: About raid5 read error handle when raid5 was degraded.
2012-05-21 10:47 About raid5 read error handle when raid5 was degraded majianpeng
@ 2012-05-21 22:36 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2012-05-21 22:36 UTC (permalink / raw)
To: majianpeng; +Cc: linux-raid
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On Mon, 21 May 2012 18:47:58 +0800 "majianpeng" <majianpeng@gmail.com> wrote:
> Hi all:
> I readed the latest code in function :
>
> raid5_end_read_request():
> >> else if (conf->mddev->degraded >= conf->max_degraded)
> >> printk_ratelimited(
> >> KERN_WARNING
> >> "md/raid:%s: read error not correctable "
> >> "(sector %llu on %s).\n",
> >> mdname(conf->mddev),
> >> (unsigned long long)(sh->sector
> >> + rdev->data_offset),
> >> bdn);
>
> If this occur,then exec md_error().In md_error(), remove this disk.
> The raid5 will fail and lost all data.
> Why do call rdev_set_badsector() for this situation?
>
You are probably right - rdev_set_badblocks should probably be called there.
I've added it to my list of issues to look at when I get a chance.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-21 22:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-21 10:47 About raid5 read error handle when raid5 was degraded majianpeng
2012-05-21 22:36 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).