From: NeilBrown <neilb@suse.de>
To: Alexander Lyakas <alex.bolshoy@gmail.com>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: Question about commit 02e7c5b75cd4ad5176441add156389c71dab6e3a - avoid including wayward devices
Date: Thu, 24 May 2012 15:04:30 +1000 [thread overview]
Message-ID: <20120524150430.2bb4288c@notabene.brown> (raw)
In-Reply-To: <CAGRgLy6RFRQqB0VtV-=C2v+TCu4yKJEOR3i=zF_5yxTtVCHWZw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2065 bytes --]
On Tue, 22 May 2012 15:59:50 +0300 Alexander Lyakas <alex.bolshoy@gmail.com>
wrote:
> Hi Neil,
> can you pls give some details on that commit.
>
> As far as I understand, this change attempts to protect from
> split-brain, most typical to RAID1 (but also, e.g., to 4-drive RAID6)
> , where part of a mirrored set was assembled independently. The code
> first selects "most_recent" based on event count (as usual). Then it
> applies the map check to all those devices that are not "most_recent",
> and might kick them out, if it detects split-brain.
> However, when there is such split-brain, and parts of mirrored sets
> are assembled independently, the highest event count does not really
> tell us which part of the mirrored set is "more up-to-date". This is
> because event count is not tied to any hard clock or something like
> that. So there is really no way to tell what part of the mirrored set
> will be picked up here (WRT to user activity on the separate mirrored
> sets).
In a split brain situation *neither* side is "more up-to-date". They are
both simply "differently up-to-date". A wall-clock based event count would
not change this fact.
>
> What I am trying to say, I guess: don't you think that in such case,
> it would be better to warn the user and abort, and not pick (more or
> less) arbitrary part of the set? Or, in other words:) might you
> reconsider looking at some ideas for split-brain protection I pitched
> some time ago?:))
This is a policy question and so I am happy for an extension to the new
"policy" mechanism in mdadm to allow finer control for managing it.
I'm fairy sure that I think the default should be the current behaviour.
If you are assembling the arrays with "-I" it not really possible to reject
the first half of the brain that is found, so I don't think we should when
assembling with "-A".
I'm afraid I don't particularly remember the ideas you pitched before. Feel
free to pitch them again -- and repeat every few weeks until you get an
answer :-)
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2012-05-24 5:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 12:59 Question about commit 02e7c5b75cd4ad5176441add156389c71dab6e3a - avoid including wayward devices Alexander Lyakas
2012-05-24 5:04 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524150430.2bb4288c@notabene.brown \
--to=neilb@suse.de \
--cc=alex.bolshoy@gmail.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).