From: NeilBrown <neilb@suse.de>
To: Anton Blanchard <anton@samba.org>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] Increase minimum chunk size in testsuite to 64kB
Date: Thu, 24 May 2012 15:38:14 +1000 [thread overview]
Message-ID: <20120524153814.05cf7d70@notabene.brown> (raw)
In-Reply-To: <20120524151047.7a011be9@kryten>
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
On Thu, 24 May 2012 15:10:47 +1000 Anton Blanchard <anton@samba.org> wrote:
>
> When running the mdadm testsuite on ppc64 with a 64kB page size I
> see a couple of failures because the chunk size is smaller than a
> page.
>
> Bump the chunksize to 64kB to fix these failures.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
>
> diff --git a/tests/02r5grow b/tests/02r5grow
> index f9fd571..b91ffcd 100644
> --- a/tests/02r5grow
> +++ b/tests/02r5grow
> @@ -2,7 +2,7 @@
>
> # create a small raid5 array, make it larger. Then make it smaller
>
> -mdadm -CR $md0 -e0.90 --level raid5 --chunk=32 --raid-disks 3 --size $[size/2] $dev1 $dev2 $dev3
> +mdadm -CR $md0 -e0.90 --level raid5 --chunk=64 --raid-disks 3 --size $[size/2] $dev1 $dev2 $dev3
> check wait
> check state UUU
> testdev $md0 2 $[size/2] 32
> diff --git a/tests/02r6grow b/tests/02r6grow
> index 3f53904..38c7781 100644
> --- a/tests/02r6grow
> +++ b/tests/02r6grow
> @@ -2,7 +2,7 @@
>
> # create a small raid6 array, make it larger. Then make it smaller
>
> -mdadm -CR $md0 -e 0.90 --level raid6 --chunk=32 --raid-disks 4 --size $[size/2] $dev1 $dev2 $dev3 $dev4
> +mdadm -CR $md0 -e 0.90 --level raid6 --chunk=64 --raid-disks 4 --size $[size/2] $dev1 $dev2 $dev3 $dev4
> check wait
> check state UUUU
> testdev $md0 2 $[size/2] 32
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Applied, thanks.
And thanks for testing :-)
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2012-05-24 5:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 5:10 [PATCH] Increase minimum chunk size in testsuite to 64kB Anton Blanchard
2012-05-24 5:38 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524153814.05cf7d70@notabene.brown \
--to=neilb@suse.de \
--cc=anton@samba.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).