From: NeilBrown <neilb@suse.de>
To: Jes.Sorensen@redhat.com
Cc: dledford@redhat.com, linux-raid@vger.kernel.org
Subject: Re: [PATCH 4/4] Move setup code to a function and introduce matching cleanup argument
Date: Mon, 28 May 2012 10:56:41 +1000 [thread overview]
Message-ID: <20120528105641.7dd20b5f@notabene.brown> (raw)
In-Reply-To: <1337959448-5299-5-git-send-email-Jes.Sorensen@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
On Fri, 25 May 2012 17:24:08 +0200 Jes.Sorensen@redhat.com wrote:
> @@ -231,7 +233,7 @@ do_test() {
> if [ "$savelogs" == "1" ]; then
> cp $targetdir/log $logdir/$_basename.log
> fi
> - if [ "$_fail" == "1" -a $"exitonerror" == "1" ]; then
> + if [ "$_fail" == "1" -a "$exitonerror" == "1" ]; then
> exit 1
> fi
> fi
I merged this fix back into the previous patch that introduced the bug :-)
Otherwise - all applied,
Thanks.
I'll definitely be using the --no-error option!
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2012-05-28 0:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 15:24 [PATCH 0/4] More test suite enchancements Jes.Sorensen
2012-05-25 15:24 ` [PATCH 1/4] Add support for saving log files in test script Jes.Sorensen
2012-05-28 0:54 ` NeilBrown
2012-05-25 15:24 ` [PATCH 2/4] Add --no-error argument to 'test' Jes.Sorensen
2012-05-25 15:24 ` [PATCH 3/4] Improve --help message from test Jes.Sorensen
2012-05-25 15:24 ` [PATCH 4/4] Move setup code to a function and introduce matching cleanup argument Jes.Sorensen
2012-05-28 0:56 ` NeilBrown [this message]
2012-05-29 6:02 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120528105641.7dd20b5f@notabene.brown \
--to=neilb@suse.de \
--cc=Jes.Sorensen@redhat.com \
--cc=dledford@redhat.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).