From: majianpeng <majianpeng@gmail.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Neil Brown <neilb@suse.de>, linux-raid <linux-raid@vger.kernel.org>
Subject: Re: Re: [PATCH 2/2] md:Rewrite the md_write_start().
Date: Mon, 4 Jun 2012 09:03:57 +0800 [thread overview]
Message-ID: <201206040903521250721@gmail.com> (raw)
In-Reply-To: CAA9_cmd9CBe+GGduR7oiUvfDZagx=5NiTTUrG-HVmdqQYK_4xA@mail.gmail.com
On Sun, 3 Jun 2012 14:11:41 -0700, Dan Williams wrote:
>On Sat, Jun 2, 2012 at 1:16 AM, majianpeng <majianpeng@gmail.com> wrote:
>> Remove the judgement "bio_data_dir(bi) != WRITE" in md_write_start().Put
>> it before call md_write_start.
>>
>> Signed-off-by: majianpeng <majianpeng@gmail.com>
>> ---
>> ?drivers/md/md.c ? ? | ? ?4 +---
>> ?drivers/md/md.h ? ? | ? ?2 +-
>> ?drivers/md/raid1.c ?| ? ?4 ++--
>> ?drivers/md/raid10.c | ? ?3 ++-
>> ?drivers/md/raid5.c ?| ? ?3 ++-
>> ?5 files changed, 8 insertions(+), 8 deletions(-)
>
>If the deletions had outnumbered the insertions then maybe, but I
>think just like kfree() allowing NULL pointers it's cleaner if the
>caller need not worry.
>
>--
>Dan
The patch had a anthor reason: first check,if read so not call function.
Call function takes long time than check statment.
next prev parent reply other threads:[~2012-06-04 1:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-02 8:16 [PATCH 2/2] md:Rewrite the md_write_start() majianpeng
2012-06-03 21:11 ` Dan Williams
2012-06-04 1:03 ` majianpeng [this message]
2012-06-04 1:12 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206040903521250721@gmail.com \
--to=majianpeng@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).