From: NeilBrown <neilb@suse.de>
To: Shaohua Li <shli@kernel.org>
Cc: linux-raid@vger.kernel.org, axboe@kernel.dk
Subject: Re: [patch 1/3 v3] raid1: make sequential read detection per disk based
Date: Wed, 4 Jul 2012 15:38:45 +1000 [thread overview]
Message-ID: <20120704153845.509b5814@notabene.brown> (raw)
In-Reply-To: <20120702011025.079670656@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2076 bytes --]
On Mon, 02 Jul 2012 09:08:41 +0800 Shaohua Li <shli@kernel.org> wrote:
> Currently the sequential read detection is global wide. It's natural to make it
> per disk based, which can improve the detection for concurrent multiple
> sequential reads. And next patch will make SSD read balance not use distance
> based algorithm, where this change help detect truly sequential read for SSD.
>
> Signed-off-by: Shaohua Li <shli@fusionio.com>
> ---
> drivers/md/raid1.c | 29 ++++++-----------------------
> drivers/md/raid1.h | 11 +++++------
> 2 files changed, 11 insertions(+), 29 deletions(-)
>
> Index: linux/drivers/md/raid1.c
> ===================================================================
> --- linux.orig/drivers/md/raid1.c 2012-06-28 10:44:47.550666575 +0800
> +++ linux/drivers/md/raid1.c 2012-06-28 12:01:03.513137377 +0800
> @@ -483,7 +483,6 @@ static int read_balance(struct r1conf *c
> const sector_t this_sector = r1_bio->sector;
> int sectors;
> int best_good_sectors;
> - int start_disk;
> int best_disk;
> int i;
> sector_t best_dist;
> @@ -503,20 +502,17 @@ static int read_balance(struct r1conf *c
> best_good_sectors = 0;
>
> if (conf->mddev->recovery_cp < MaxSector &&
> - (this_sector + sectors >= conf->next_resync)) {
> + (this_sector + sectors >= conf->next_resync))
> choose_first = 1;
> - start_disk = 0;
> - } else {
> + else
> choose_first = 0;
> - start_disk = conf->last_used;
> - }
>
> for (i = 0 ; i < conf->raid_disks * 2 ; i++) {
> sector_t dist;
> sector_t first_bad;
> int bad_sectors;
>
> - int disk = start_disk + i;
> + int disk = i;
> if (disk >= conf->raid_disks)
> disk -= conf->raid_disks;
One last little change please. Could you make that loop:
for (disk = 0; disk < conf->raid_disks * 2; disk++)
and remote the 'if' statement that wraps 'disk' back to zero
when it gets too big (which is buggy and has been fixed in my for-next).
With that change I'll take the patch.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2012-07-04 5:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 1:08 [patch 0/3 v3] Optimize raid1 read balance for SSD Shaohua Li
2012-07-02 1:08 ` [patch 1/3 v3] raid1: make sequential read detection per disk based Shaohua Li
2012-07-04 5:38 ` NeilBrown [this message]
2012-07-02 1:08 ` [patch 2/3 v3] raid1: read balance chooses idlest disk for SSD Shaohua Li
2012-07-02 2:13 ` Roberto Spadim
2012-07-02 3:02 ` Shaohua Li
2012-07-02 3:57 ` Roberto Spadim
2012-07-02 4:33 ` Roberto Spadim
2012-07-02 4:31 ` Roberto Spadim
2012-07-02 4:36 ` Roberto Spadim
2012-07-04 5:45 ` NeilBrown
2012-07-02 1:08 ` [patch 3/3 v3] raid1: prevent merging too large request Shaohua Li
2012-07-04 5:59 ` NeilBrown
2012-07-04 8:01 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120704153845.509b5814@notabene.brown \
--to=neilb@suse.de \
--cc=axboe@kernel.dk \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).