From: NeilBrown <neilb@suse.de>
To: Sebastian Hegler <sebastian.hegler@tu-dresden.de>
Cc: linux-raid@vger.kernel.org, 681056@bugs.debian.org
Subject: Re: mdadm-3.2.5: segfault in "--grow --continue"
Date: Wed, 11 Jul 2012 12:26:26 +1000 [thread overview]
Message-ID: <20120711122626.51cf7070@notabene.brown> (raw)
In-Reply-To: <BC57DF1E-7CA3-429E-8935-44A94003B5E5@tu-dresden.de>
[-- Attachment #1: Type: text/plain, Size: 904 bytes --]
On Tue, 10 Jul 2012 18:51:22 +0200 Sebastian Hegler
<sebastian.hegler@tu-dresden.de> wrote:
> Hi!
>
Hi,
thanks for all the extra details.
I should have asked which kernel you were running. I'm guessing that it is
earlier than 2.6.25, and so is missing upstream commit
25156198235325805cd7295ed694509fd6e3a29e
that fixes a bug which causes reshape not to restart if array was assembled
auto-read-only.
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=25156198235325805cd7295ed694509fd6e3a29e
The mdadm bug is because we never tested the code with anything but IMSM
arrays because those are the only ones that need to use it.
Adding a test for 'mdstat' being NULL and not trying to call
verify_reshape_position in that case is the simplest fixed I expect, though I
haven't tested yet. Possibly something more thorough is needed.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2012-07-11 2:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 10:46 mdadm-3.2.5: segfault in "--grow --continue" Sebastian Hegler
2012-07-10 13:02 ` NeilBrown
2012-07-10 16:51 ` Sebastian Hegler
2012-07-11 2:26 ` NeilBrown [this message]
2012-07-11 11:15 ` Sebastian Hegler
2012-07-16 6:26 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120711122626.51cf7070@notabene.brown \
--to=neilb@suse.de \
--cc=681056@bugs.debian.org \
--cc=linux-raid@vger.kernel.org \
--cc=sebastian.hegler@tu-dresden.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).